Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2847143002: Fix KernelEquivalence.entityEquivalence for equi-named instance/top-level members (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix KernelEquivalence.entityEquivalence for equi-named instance/top-level members + add logging to closed_world_tester. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8af3ebc0202f05c915e4f4a99a24716a785339f4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -60 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 5 chunks +13 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_tester.dart View 1 1 chunk +104 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 2 chunks +16 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-04-28 14:13:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2847143002/diff/1/tests/compiler/dart2js/kernel/closed_world_tester.dart File tests/compiler/dart2js/kernel/closed_world_tester.dart (right): https://codereview.chromium.org/2847143002/diff/1/tests/compiler/dart2js/kernel/closed_world_tester.dart#newcode26 tests/compiler/dart2js/kernel/closed_world_tester.dart:26: if (FileSystemEntity.isFileSync(logName)) { consider moving this if to ...
3 years, 7 months ago (2017-04-28 22:30:38 UTC) #3
Johnni Winther
https://codereview.chromium.org/2847143002/diff/1/tests/compiler/dart2js/kernel/closed_world_tester.dart File tests/compiler/dart2js/kernel/closed_world_tester.dart (right): https://codereview.chromium.org/2847143002/diff/1/tests/compiler/dart2js/kernel/closed_world_tester.dart#newcode26 tests/compiler/dart2js/kernel/closed_world_tester.dart:26: if (FileSystemEntity.isFileSync(logName)) { On 2017/04/28 22:30:38, Siggi Cherem (dart-lang) ...
3 years, 7 months ago (2017-05-01 07:47:23 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-01 07:59:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8af3ebc0202f05c915e4f4a99a24716a785339f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698