Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: net/spdy/chromium/spdy_session_unittest.cc

Issue 2847133003: Add NetLog event for invalid Http/2 response header (Closed)
Patch Set: fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/chromium/spdy_session_unittest.cc
diff --git a/net/spdy/chromium/spdy_session_unittest.cc b/net/spdy/chromium/spdy_session_unittest.cc
index 57bfa214e1010e232bae6f905a18afe32b0f58f3..a19ff1b4bb9aff0d0463fd944d31c9d9c7d50c91 100644
--- a/net/spdy/chromium/spdy_session_unittest.cc
+++ b/net/spdy/chromium/spdy_session_unittest.cc
@@ -2851,7 +2851,7 @@ TEST_F(SpdySessionTest, ReadDataWithoutYielding) {
session_deps_.host_resolver->set_synchronous_mode(true);
session_deps_.time_func = InstantaneousReads;
- BufferedSpdyFramer framer;
+ BufferedSpdyFramer framer((NetLogWithSource()));
SpdySerializedFrame req1(
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, MEDIUM, true));
@@ -3064,7 +3064,7 @@ TEST_F(SpdySessionTest, TestYieldingDuringReadData) {
session_deps_.host_resolver->set_synchronous_mode(true);
session_deps_.time_func = InstantaneousReads;
- BufferedSpdyFramer framer;
+ BufferedSpdyFramer framer((NetLogWithSource()));
Bence 2017/05/10 12:43:29 I think there is an extra pair of () here that sho
xunjieli 2017/05/10 18:24:59 Done.
SpdySerializedFrame req1(
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, MEDIUM, true));
@@ -3158,7 +3158,7 @@ TEST_F(SpdySessionTest, TestYieldingDuringAsyncReadData) {
session_deps_.host_resolver->set_synchronous_mode(true);
session_deps_.time_func = InstantaneousReads;
- BufferedSpdyFramer framer;
+ BufferedSpdyFramer framer((NetLogWithSource()));
Bence 2017/05/10 12:43:29 Same here.
xunjieli 2017/05/10 18:24:59 Done.
SpdySerializedFrame req1(
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, MEDIUM, true));

Powered by Google App Engine
This is Rietveld 408576698