Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: net/spdy/chromium/buffered_spdy_framer.h

Issue 2847133003: Add NetLog event for invalid Http/2 response header (Closed)
Patch Set: fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/chromium/buffered_spdy_framer.h
diff --git a/net/spdy/chromium/buffered_spdy_framer.h b/net/spdy/chromium/buffered_spdy_framer.h
index 9830425a8dd705d1b83a39fbcb6fe217267a9bfb..d7cb546019fa37bdf685037e2b74f6ba8c1d0cde 100644
--- a/net/spdy/chromium/buffered_spdy_framer.h
+++ b/net/spdy/chromium/buffered_spdy_framer.h
@@ -12,6 +12,7 @@
#include "base/macros.h"
#include "net/base/net_export.h"
+#include "net/log/net_log_source.h"
#include "net/spdy/chromium/header_coalescer.h"
#include "net/spdy/core/spdy_alt_svc_wire_format.h"
#include "net/spdy/core/spdy_framer.h"
@@ -120,7 +121,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramerVisitorInterface {
class NET_EXPORT_PRIVATE BufferedSpdyFramer
: public SpdyFramerVisitorInterface {
public:
- BufferedSpdyFramer();
+ explicit BufferedSpdyFramer(const NetLogWithSource& net_log);
Bence 2017/05/10 12:43:29 Please delete default constructor to avoid inadver
xunjieli 2017/05/10 18:24:59 Done.
~BufferedSpdyFramer() override;
// Sets callbacks to be called from the buffered spdy framer. A visitor must
@@ -270,6 +271,8 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer
std::unique_ptr<HeaderCoalescer> coalescer_;
+ NetLogWithSource net_log_;
+
DISALLOW_COPY_AND_ASSIGN(BufferedSpdyFramer);
};

Powered by Google App Engine
This is Rietveld 408576698