Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: net/spdy/chromium/header_coalescer.h

Issue 2847133003: Add NetLog event for invalid Http/2 response header (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_HEADER_COALESCER_H_ 5 #ifndef NET_SPDY_HEADER_COALESCER_H_
6 #define NET_SPDY_HEADER_COALESCER_H_ 6 #define NET_SPDY_HEADER_COALESCER_H_
7 7
8 #include "net/base/net_export.h" 8 #include "net/base/net_export.h"
9 #include "net/log/net_log_with_source.h"
9 #include "net/spdy/core/spdy_header_block.h" 10 #include "net/spdy/core/spdy_header_block.h"
10 #include "net/spdy/core/spdy_headers_handler_interface.h" 11 #include "net/spdy/core/spdy_headers_handler_interface.h"
11 #include "net/spdy/platform/api/spdy_string_piece.h" 12 #include "net/spdy/platform/api/spdy_string_piece.h"
12 13
13 namespace net { 14 namespace net {
14 15
15 class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface { 16 class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {
16 public: 17 public:
17 HeaderCoalescer() {} 18 HeaderCoalescer(const NetLogWithSource& net_log);
Bence 2017/04/28 18:08:35 explicit
xunjieli 2017/05/10 01:13:48 Done.
18 19
19 void OnHeaderBlockStart() override {} 20 void OnHeaderBlockStart() override {}
20 21
21 void OnHeader(SpdyStringPiece key, SpdyStringPiece value) override; 22 void OnHeader(SpdyStringPiece key, SpdyStringPiece value) override;
22 23
23 void OnHeaderBlockEnd(size_t uncompressed_header_bytes) override {} 24 void OnHeaderBlockEnd(size_t uncompressed_header_bytes) override {}
24 void OnHeaderBlockEnd(size_t uncompressed_header_bytes, 25 void OnHeaderBlockEnd(size_t uncompressed_header_bytes,
25 size_t compressed_header_bytes) override {} 26 size_t compressed_header_bytes) override {}
26 27
27 SpdyHeaderBlock release_headers(); 28 SpdyHeaderBlock release_headers();
28 bool error_seen() const { return error_seen_; } 29 bool error_seen() const { return error_seen_; }
29 30
30 // Returns the estimate of dynamically allocated memory in bytes. 31 // Returns the estimate of dynamically allocated memory in bytes.
31 size_t EstimateMemoryUsage() const; 32 size_t EstimateMemoryUsage() const;
32 33
33 private: 34 private:
35 // Helper to add a header. Return true on success.
36 bool AddHeader(SpdyStringPiece key, SpdyStringPiece value);
37
34 SpdyHeaderBlock headers_; 38 SpdyHeaderBlock headers_;
35 bool headers_valid_ = true; 39 bool headers_valid_ = true;
36 size_t header_list_size_ = 0; 40 size_t header_list_size_ = 0;
37 bool error_seen_ = false; 41 bool error_seen_ = false;
38 bool regular_header_seen_ = false; 42 bool regular_header_seen_ = false;
43 NetLogWithSource net_log_;
39 }; 44 };
40 45
41 } // namespace net 46 } // namespace net
42 47
43 #endif // NET_SPDY_HEADER_COALESCER_H_ 48 #endif // NET_SPDY_HEADER_COALESCER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698