Fix --kiosk to work regardless of the startup pref setting or supplied URLs. ...

Fix --kiosk to work regardless of the startup pref setting or supplied URLs. 

This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive().  This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message.

BUG=none 
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54643

[Peter Kasting, 2010-07-29 22:27:56]

Zel, the browser_init.cc part was previously r+ed, so the only bit to review is
the browser_view.cc change.

[Peter Kasting, 2010-08-02 19:33:50]

ping

[Peter Kasting, 2010-08-02 22:54:59]

Changing reviewer to sky since Zel doesn't seem to be around and sky has a
chance of knowing what I'm doing in browser_view.cc.

[sky, 2010-08-02 23:07:33]

http://codereview.chromium.org/2847090/diff/1/2
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/2847090/diff/1/2#newcode558
chrome/browser/browser_init.cc:558:
BrowserList::GetLastActive()->ToggleFullscreenMode();
GetLastActive can return null during startup (see warning in browserlist).

http://codereview.chromium.org/2847090/diff/1/3
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/2847090/diff/1/3#newcode679
chrome/browser/views/frame/browser_view.cc:679: // browser at the time Show() is
called. This is the natural behaviour under
behaviour? Do you think you're British?

[Peter Kasting, 2010-08-02 23:36:13]

New snap up.

http://codereview.chromium.org/2847090/diff/1/2
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/2847090/diff/1/2#newcode558
chrome/browser/browser_init.cc:558:
BrowserList::GetLastActive()->ToggleFullscreenMode();
On 2010/08/02 23:07:33, sky wrote:
> GetLastActive can return null during startup (see warning in browserlist).

After checking, I believe all platforms should call BrowserWindow::Show() during
launch, and that will always synchronously call SetLastActive() (now that I'm
fixing it on Linux View).  So I think the comment is no longer accurate.  I
changed it.

http://codereview.chromium.org/2847090/diff/1/3
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/2847090/diff/1/3#newcode679
chrome/browser/views/frame/browser_view.cc:679: // browser at the time Show() is
called. This is the natural behaviour under
On 2010/08/02 23:07:33, sky wrote:
> behaviour? Do you think you're British?

Fixed.

[sky, 2010-08-02 23:42:46]

LGTM