Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: base/memory/shared_memory_handle.h

Issue 2847033003: Get rid of SharedMemory::GiveToProcess. (Closed)
Patch Set: Comments from avi. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/shared_memory.h ('k') | base/memory/shared_memory_handle_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_handle.h
diff --git a/base/memory/shared_memory_handle.h b/base/memory/shared_memory_handle.h
index c0a016f5dcdd94d3b3b01ff89ec1f91c4e6035d6..228e8216c9f39354b8f978361b8a28722e32faa2 100644
--- a/base/memory/shared_memory_handle.h
+++ b/base/memory/shared_memory_handle.h
@@ -56,6 +56,9 @@ class BASE_EXPORT SharedMemoryHandle {
// Whether the underlying OS resource is valid.
bool IsValid() const;
+ // Duplicates the underlying OS resource.
+ SharedMemoryHandle Duplicate() const;
+
#if defined(OS_MACOSX) && !defined(OS_IOS)
enum Type {
// The SharedMemoryHandle is backed by a POSIX fd.
@@ -83,9 +86,6 @@ class BASE_EXPORT SharedMemoryHandle {
mach_vm_size_t size,
base::ProcessId pid);
- // Duplicates the underlying OS resources.
- SharedMemoryHandle Duplicate() const;
-
// Exposed so that the SharedMemoryHandle can be transported between
// processes.
mach_port_t GetMemoryObject() const;
@@ -131,9 +131,6 @@ class BASE_EXPORT SharedMemoryHandle {
// Invalidates [but doesn't close] the underlying OS resource. This will leak
// unless the caller is careful.
int Release();
-
- // Duplicates the underlying OS resource.
- SharedMemoryHandle Duplicate() const;
#endif
private:
« no previous file with comments | « base/memory/shared_memory.h ('k') | base/memory/shared_memory_handle_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698