Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2538)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/memory/shared_memory_nacl.cc

Issue 2847033003: Get rid of SharedMemory::GiveToProcess. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/memory/shared_memory_handle_win.cc ('K') | « base/memory/shared_memory_mac.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | base/memory/shared_memory_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_nacl.cc
diff --git a/base/memory/shared_memory_nacl.cc b/base/memory/shared_memory_nacl.cc
index 32c321068158d5c3fa4e8228e9bdb8c91e27a78a..8e3387699c5e38ea2cc2dc687b2708e664ddbf76 100644
--- a/base/memory/shared_memory_nacl.cc
+++ b/base/memory/shared_memory_nacl.cc
@@ -132,13 +132,8 @@ SharedMemoryHandle SharedMemory::GetReadOnlyHandle() {
}
bool SharedMemory::ShareToProcessCommon(ProcessHandle process,
- SharedMemoryHandle* new_handle,
- bool close_self) {
+ SharedMemoryHandle* new_handle) {
*new_handle = shm_.Duplicate();
- if (close_self) {
- Unmap();
- Close();
- }
return new_handle->IsValid();
}
« base/memory/shared_memory_handle_win.cc ('K') | « base/memory/shared_memory_mac.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | base/memory/shared_memory_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698