Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2847003004: [ObjC ARC] Converts ios/chrome/browser/ui/util:unit_tests to ARC. (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/util:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2847003004 Cr-Commit-Position: refs/heads/master@{#468679} Committed: https://chromium.googlesource.com/chromium/src/+/89a19c7dd35d9d855fc11b75a154ebbe2ae68c2b

Patch Set 1 #

Patch Set 2 : Fix test #

Total comments: 12

Patch Set 3 : Address comments #

Total comments: 10

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -137 lines) Patch
M ios/chrome/browser/ui/util/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm View 1 2 3 7 chunks +24 lines, -29 lines 0 comments Download
M ios/chrome/browser/ui/util/core_text_util_unittest.mm View 4 chunks +19 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/util/label_link_controller_unittest.mm View 1 2 3 11 chunks +35 lines, -34 lines 0 comments Download
M ios/chrome/browser/ui/util/label_observer_unittest.mm View 1 2 3 1 chunk +11 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/util/manual_text_framer_unittest.mm View 1 2 3 6 chunks +15 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/util/text_region_mapper_unittest.mm View 1 2 5 chunks +26 lines, -29 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
gambard
PTAL.
3 years, 7 months ago (2017-05-02 06:35:38 UTC) #8
stkhapugin
LGTM with nits https://codereview.chromium.org/2847003004/diff/20001/ios/chrome/browser/ui/util/label_link_controller_unittest.mm File ios/chrome/browser/ui/util/label_link_controller_unittest.mm (right): https://codereview.chromium.org/2847003004/diff/20001/ios/chrome/browser/ui/util/label_link_controller_unittest.mm#newcode99 ios/chrome/browser/ui/util/label_link_controller_unittest.mm:99: llc = [[LabelLinkController alloc] initWithLabel:label_ action:nullptr]; ...
3 years, 7 months ago (2017-05-02 12:43:39 UTC) #9
gambard
Thanks, sdefresne@: PTAL. https://codereview.chromium.org/2847003004/diff/20001/ios/chrome/browser/ui/util/label_link_controller_unittest.mm File ios/chrome/browser/ui/util/label_link_controller_unittest.mm (right): https://codereview.chromium.org/2847003004/diff/20001/ios/chrome/browser/ui/util/label_link_controller_unittest.mm#newcode99 ios/chrome/browser/ui/util/label_link_controller_unittest.mm:99: llc = [[LabelLinkController alloc] initWithLabel:label_ action:nullptr]; ...
3 years, 7 months ago (2017-05-02 12:54:09 UTC) #11
sdefresne
lgtm with comments and followups https://codereview.chromium.org/2847003004/diff/40001/ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm File ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm (right): https://codereview.chromium.org/2847003004/diff/40001/ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm#newcode42 ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm:42: } nit, optional: } ...
3 years, 7 months ago (2017-05-02 14:07:34 UTC) #12
gambard
Thanks! https://codereview.chromium.org/2847003004/diff/40001/ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm File ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm (right): https://codereview.chromium.org/2847003004/diff/40001/ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm#newcode42 ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm:42: } On 2017/05/02 14:07:33, sdefresne wrote: > nit, ...
3 years, 7 months ago (2017-05-02 15:26:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847003004/60001
3 years, 7 months ago (2017-05-02 15:26:59 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:44:05 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/89a19c7dd35d9d855fc11b75a154...

Powered by Google App Engine
This is Rietveld 408576698