Add more navigation tracing to RenderFrameHost and NavigationRequest.

content/browser/frame_host/navigation_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 
 #include <memory>
 
 #include "base/callback_forward.h"
@@ skipping 116 matching lines @@
   RestoreType restore_type() const { return restore_type_; };
 
   bool is_view_source() const { return is_view_source_; };
 
   int bindings() const { return bindings_; };
 
   bool browser_initiated() const { return browser_initiated_ ; }
 
   bool may_transfer() const { return may_transfer_; }
 
-  void SetWaitingForRendererResponse() {
-    DCHECK(state_ == NOT_STARTED);
-    state_ = WAITING_FOR_RENDERER_RESPONSE;
-  }
-
   AssociatedSiteInstanceType associated_site_instance_type() const {
     return associated_site_instance_type_;
   }
   void set_associated_site_instance_type(AssociatedSiteInstanceType type) {

[clamy, 2017/04/28 14:07:15]

I'm wondering if we should also trace this, possibly with the RFH/RPH ids of the
speculative RFH. Same when we commit.

[nasko, 2017/04/28 14:18:56]

Sure. I'll try to add this.

[nasko, 2017/04/28 15:58:56]

I looked at this and it seems more appropriate to trace RFH/RPH from the caller
of this method, which is RFHM. There is probably other interesting state to
trace in RFHM, so I'll do it in a separate CL altogether.

     associated_site_instance_type_ = type;
   }
 
   NavigationHandleImpl* navigation_handle() const {
     return navigation_handle_.get();
   }
 
+  void SetWaitingForRendererResponse();
+
   // Creates a NavigationHandle. This should be called after any previous
   // NavigationRequest for the FrameTreeNode has been destroyed.
   void CreateNavigationHandle(int pending_nav_entry_id);
 
   // Transfers the ownership of the NavigationHandle to |render_frame_host|.
   // This should be called when the navigation is ready to commit, because the
   // NavigationHandle outlives the NavigationRequest. The NavigationHandle's
   // lifetime is the entire navigation, while the NavigationRequest is
   // destroyed when a navigation is ready for commit.
   void TransferNavigationHandleOwnership(
@@ skipping 95 matching lines @@
   mojo::ScopedDataPipeConsumerHandle handle_;
 
   base::Closure on_start_checks_complete_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationRequest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_