Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2846963004: Re-organize and comment clean-up (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -87 lines) Patch
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol.dart View 1 chunk +2 lines, -0 lines 0 comments Download
D pkg/analyzer_plugin/lib/utilities/subscription_manager.dart View 1 chunk +0 lines, -44 lines 0 comments Download
A + pkg/analyzer_plugin/lib/utilities/subscriptions/subscription_manager.dart View 1 chunk +2 lines, -0 lines 0 comments Download
D pkg/analyzer_plugin/test/utilities/subscription_manager_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
A + pkg/analyzer_plugin/test/utilities/subscriptions/subscription_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer_plugin/test/utilities/subscriptions/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/test/utilities/test_all.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-04-28 14:27:04 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-04-28 15:39:51 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-04-28 16:10:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91fede471f3176df60d1bd2c22f4a72e84c59370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698