Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h

Issue 2846913002: Add a Certificate Viewer link to the Page Info dropdown (Closed)
Patch Set: Address nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h b/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
index 1621db3a84fe96aaba50b6d603617ddca02b4da4..b78f1300c7372ff7c11f225639e318122d8035e6 100644
--- a/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
@@ -16,6 +16,7 @@
#include "content/public/browser/web_contents_observer.h"
class PageInfoUIBridge;
+@class InspectLinkView;
namespace content {
class WebContents;
@@ -30,7 +31,7 @@ struct SecurityInfo;
} // namespace security_state
// This NSWindowController subclass manages the InfoBubbleWindow and view that
-// are displayed when the user clicks the favicon or security lock icon.
+// are displayed when the user clicks the omnibox security indicator icon.
@interface PageInfoBubbleController : OmniboxDecorationBubbleController {
@private
content::WebContents* webContents_;
@@ -62,7 +63,7 @@ struct SecurityInfo;
NSTextField* resetDecisionsField_;
// The link button for revoking certificate decisions.
- // This link only shows when there is an acrive certificate exception.
+ // This link only shows when there is an active certificate exception.
NSButton* resetDecisionsButton_;
// The server certificate from the identity info. This should always be
@@ -75,8 +76,11 @@ struct SecurityInfo;
// Container for the site settings section.
NSView* siteSettingsSectionView_;
+ // Container for certificate info in the site settings section.
+ InspectLinkView* certificateView_;
+
// Container for cookies info in the site settings section.
- NSView* cookiesView_;
+ InspectLinkView* cookiesView_;
// Container for permission info in the site settings section.
NSView* permissionsView_;

Powered by Google App Engine
This is Rietveld 408576698