Add a Certificate Viewer link to the Page Info dropdown

chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h

Index: chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h b/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
index 1621db3a84fe96aaba50b6d603617ddca02b4da4..1cc6bfd59ea4056d0bc611f10f9c5fb74db5c975 100644
--- a/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
@@ -14,6 +14,7 @@
 #import "chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h"
 #include "chrome/browser/ui/page_info/page_info_ui.h"
 #include "content/public/browser/web_contents_observer.h"
+#import "ui/base/cocoa/flipped_view.h"
 
 class PageInfoUIBridge;
 
@@ -29,8 +30,16 @@ namespace security_state {
 struct SecurityInfo;
 }  // namespace security_state
 
+@interface InspectLinkView : FlippedView {

[Robert Sesek, 2017/04/27 18:08:56]

You can forward declare this with @class and put it entirely in the .mm file.

[Robert Sesek, 2017/04/27 18:08:56]

Please give this a brief top-level comment.

[elawrence, 2017/04/27 21:44:25]

Done.

[elawrence, 2017/04/27 21:44:25]

Done.

+ @private

[Robert Sesek, 2017/04/27 18:08:56]

After this moves into the .mm file, you can also declare the instance variables
in the @implementation:

@interface InspectLinkView : FlippedView
@end

@implementation InspectLinkView () {
  NSButton* actionLink_;
}
...
@end

[elawrence, 2017/04/27 21:44:25]

Done.

+  NSButton* actionLink_;
+}
+
+- (id)initWithFrame:(NSRect)frame;

[Robert Sesek, 2017/04/27 18:08:56]

You can omit common designated initializers for view subclasses.

[elawrence, 2017/04/27 21:44:25]

Done.

+@end
+
 // This NSWindowController subclass manages the InfoBubbleWindow and view that
-// are displayed when the user clicks the favicon or security lock icon.
+// are displayed when the user clicks the omnibox security indicator icon.
 @interface PageInfoBubbleController : OmniboxDecorationBubbleController {
  @private
   content::WebContents* webContents_;
@@ -62,7 +71,7 @@ struct SecurityInfo;
   NSTextField* resetDecisionsField_;
 
   // The link button for revoking certificate decisions.
-  // This link only shows when there is an acrive certificate exception.
+  // This link only shows when there is an active certificate exception.
   NSButton* resetDecisionsButton_;
 
   // The server certificate from the identity info. This should always be
@@ -75,8 +84,11 @@ struct SecurityInfo;
   // Container for the site settings section.
   NSView* siteSettingsSectionView_;
 
+  // Container for certificate info in the site settings section.
+  InspectLinkView* certificateView_;
+
   // Container for cookies info in the site settings section.
-  NSView* cookiesView_;
+  InspectLinkView* cookiesView_;
 
   // Container for permission info in the site settings section.
   NSView* permissionsView_;