third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp - Issue 2846843002: [blink] Unique pointers in Platform.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)

Patch Set: fix content_shell compilation Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media_capture_from_element/canvas_capture_handler.cc ('K') | « third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp ('k') | third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp » ('j') | third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp

diff --git a/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp b/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp

index 812d9b2b18adb935772a372fca470d9cf5707867..5f3fbb1ff93764484c8aa8cd61f6d4ea14585bc6 100644

--- a/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp

+++ b/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp

@@ -137,7 +137,7 @@ ScriptPromise MediaCapabilities::encodingInfo(

return promise;

}

- WebMediaRecorderHandler* handler =

+ std::unique_ptr<WebMediaRecorderHandler> handler =

Platform::Current()->CreateMediaRecorderHandler();

if (!handler) {

resolver->Reject(DOMException::Create(