third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp - Issue 2846843002: [blink] Unique pointers in Platform.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)

Patch Set: fix content_shell compilation Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media_capture_from_element/canvas_capture_handler.cc ('K') | « third_party/WebKit/Source/modules/cachestorage/GlobalCacheStorage.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp » ('j') | third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

index a791b9fdebde9663fa24ad8650e9c5df463c29a4..7ed3dae7f0539118182bc738a15e64aa7cda877c 100644

--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

@@ -75,8 +75,8 @@ Response AssertCacheStorage(

if (!sec_origin->IsPotentiallyTrustworthy())

return Response::Error(sec_origin->IsPotentiallyTrustworthyErrorMessage());

- std::unique_ptr<WebServiceWorkerCacheStorage> cache = WTF::WrapUnique(

- Platform::Current()->CacheStorage(WebSecurityOrigin(sec_origin)));

+ std::unique_ptr<WebServiceWorkerCacheStorage> cache =

+ Platform::Current()->CreateCacheStorage(WebSecurityOrigin(sec_origin));

if (!cache)

return Response::Error("Could not find cache storage.");

result = std::move(cache);