Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2909)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)
Patch Set: fix content_shell compilation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 096997042ba104fc3b2d6947e06f55c138da8e5f..66c81ece0095c5d9486cc4cddd1ad14f7ff6012f 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -648,8 +648,6 @@ void RenderThreadImpl::Init(
kMaxResourceRequestsPerFlushWhenThrottled));
resource_dispatcher()->set_message_sender(resource_dispatch_throttler_.get());
- media_stream_center_ = nullptr;
-
blob_message_filter_ = new BlobMessageFilter(GetFileThreadTaskRunner());
AddFilter(blob_message_filter_.get());
db_message_filter_ = new DBMessageFilter();
@@ -1984,20 +1982,22 @@ RenderThreadImpl::RequestCopyOfOutputForLayoutTest(
return layout_test_deps_->RequestCopyOfOutput(routing_id, std::move(request));
}
-blink::WebMediaStreamCenter* RenderThreadImpl::CreateMediaStreamCenter(
+std::unique_ptr<blink::WebMediaStreamCenter>
+RenderThreadImpl::CreateMediaStreamCenter(
blink::WebMediaStreamCenterClient* client) {
+ std::unique_ptr<blink::WebMediaStreamCenter> media_stream_center;
#if BUILDFLAG(ENABLE_WEBRTC)
- if (!media_stream_center_) {
- media_stream_center_ = GetContentClient()->renderer()
- ->OverrideCreateWebMediaStreamCenter(client);
- if (!media_stream_center_) {
- std::unique_ptr<MediaStreamCenter> media_stream_center(
- new MediaStreamCenter(client, GetPeerConnectionDependencyFactory()));
- media_stream_center_ = media_stream_center.release();
+ if (!media_stream_center) {
+ media_stream_center =
+ GetContentClient()->renderer()->OverrideCreateWebMediaStreamCenter(
+ client);
+ if (!media_stream_center) {
+ media_stream_center = base::MakeUnique<MediaStreamCenter>(
+ client, GetPeerConnectionDependencyFactory());
}
}
#endif
- return media_stream_center_;
+ return media_stream_center;
}
#if BUILDFLAG(ENABLE_WEBRTC)

Powered by Google App Engine
This is Rietveld 408576698