Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/ppapi_plugin/ppapi_blink_platform_impl.cc

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)
Patch Set: fix content_shell compilation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/ppapi_plugin/ppapi_blink_platform_impl.h ('k') | content/public/renderer/content_renderer_client.h » ('j') | content/renderer/media/renderer_webaudiodevice_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/ppapi_plugin/ppapi_blink_platform_impl.cc
diff --git a/content/ppapi_plugin/ppapi_blink_platform_impl.cc b/content/ppapi_plugin/ppapi_blink_platform_impl.cc
index b13765a4948e29ac0c2a3cb287f644646855ced6..f1acb17f996a315af543baa274dc1aeb936d40ae 100644
--- a/content/ppapi_plugin/ppapi_blink_platform_impl.cc
+++ b/content/ppapi_plugin/ppapi_blink_platform_impl.cc
@@ -16,6 +16,7 @@
#include "content/common/child_process_messages.h"
#include "ppapi/proxy/plugin_globals.h"
#include "ppapi/shared_impl/proxy_lock.h"
+#include "third_party/WebKit/public/platform/WebStorageNamespace.h"
#include "third_party/WebKit/public/platform/WebString.h"
#if defined(OS_MACOSX)
@@ -222,7 +223,7 @@ blink::WebData PpapiBlinkPlatformImpl::LoadResource(const char* name) {
return blink::WebData();
}
-blink::WebStorageNamespace*
+std::unique_ptr<blink::WebStorageNamespace>
PpapiBlinkPlatformImpl::CreateLocalStorageNamespace() {
NOTREACHED();
return 0;
clamy 2017/04/27 12:00:18 I'd rather we return nullptr here.
altimin 2017/04/27 12:06:30 Done.
« no previous file with comments | « content/ppapi_plugin/ppapi_blink_platform_impl.h ('k') | content/public/renderer/content_renderer_client.h » ('j') | content/renderer/media/renderer_webaudiodevice_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698