content/renderer/media_capture_from_element/canvas_capture_handler.h - Issue 2846843002: [blink] Unique pointers in Platform.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media_capture_from_element/canvas_capture_handler.h

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)

Patch Set: fix compilation (and again) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.cc ('k') | content/renderer/media_capture_from_element/canvas_capture_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media_capture_from_element/canvas_capture_handler.h

diff --git a/content/renderer/media_capture_from_element/canvas_capture_handler.h b/content/renderer/media_capture_from_element/canvas_capture_handler.h

index 7f4e6ac2a099e8da80f046eb255d0d16865a115b..c6ed54862e4a5186161f2e3c0e9c63e9c251e69c 100644

--- a/content/renderer/media_capture_from_element/canvas_capture_handler.h

+++ b/content/renderer/media_capture_from_element/canvas_capture_handler.h

@@ -42,7 +42,7 @@ class CONTENT_EXPORT CanvasCaptureHandler final

~CanvasCaptureHandler() override;

// Creates a CanvasCaptureHandler instance and updates UMA histogram.

- static CanvasCaptureHandler* CreateCanvasCaptureHandler(

+ static std::unique_ptr<CanvasCaptureHandler> CreateCanvasCaptureHandler(

const blink::WebSize& size,

double frame_rate,

const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,