[DONT COMMIT] Worker: Add checks in InProcessWorkerObjectProxy for debug

Worker: Add checks in InProcessWorkerObjectProxy for debug

BUG=713914

[nhiroki, 2017-04-27 07:17:50]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 07:18:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-27 07:18:06]

nhiroki@chromium.org changed reviewers:
+ horo@chromium.org

[nhiroki, 2017-04-27 07:18:07]

PTAL, thanks!

[horo, 2017-04-27 07:46:16]

On 2017/04/27 07:18:07, nhiroki wrote:
> PTAL, thanks!

Do you need to land this patch?
Can't you reproduce the issue 713914?

[nhiroki, 2017-04-27 07:50:36]

On 2017/04/27 07:46:16, horo wrote:
> On 2017/04/27 07:18:07, nhiroki wrote:
> > PTAL, thanks!
> 
> Do you need to land this patch?
> Can't you reproduce the issue 713914?

Unfortunately, I cannot reproduce this on my local machine and try servers (see
also issue 713685). Probably this depends on timing. Just in case, I'll try it
one more time in another machine.

[horo, 2017-04-27 08:25:29]

On 2017/04/27 07:50:36, nhiroki wrote:
> On 2017/04/27 07:46:16, horo wrote:
> > On 2017/04/27 07:18:07, nhiroki wrote:
> > > PTAL, thanks!
> > 
> > Do you need to land this patch?
> > Can't you reproduce the issue 713914?
> 
> Unfortunately, I cannot reproduce this on my local machine and try servers
(see
> also issue 713685). Probably this depends on timing. Just in case, I'll try it
> one more time in another machine.

I could reproduce the crash with this CL.

crash log for renderer (pid <unknown>):
STDOUT: #CRASHED - renderer
STDERR:
[1:12:0427/172406.542232:3225032548415:FATAL:InProcessWorkerObjectProxy.cpp(157)]
Check failed: !was_destroyed_. 
STDERR: #0 0x7fa6d50f17db base::debug::StackTrace::StackTrace()
STDERR: #1 0x7fa6d50f04dc base::debug::StackTrace::StackTrace()
STDERR: #2 0x7fa6d5163bf3 logging::LogMessage::~LogMessage()
STDERR: #3 0x7fa6cda2762a
blink::InProcessWorkerObjectProxy::StartPendingActivityTimer()
STDERR: #4 0x7fa6cda274c8
blink::InProcessWorkerObjectProxy::ProcessMessageFromWorkerObject()
STDERR: #5 0x7fa6cda25380
_ZN4base8internal13FunctorTraitsIMN5blink26InProcessWorkerObjectProxyEFvN3WTF10PassRefPtrINS2_21SerializedScriptValueEEENS4_6VectorISt10unique_ptrINS2_21WebMessagePortChannelESt14default_deleteISA_EELm1ENS4_18PartitionAllocatorEEEPNS2_12WorkerThreadEEvE6InvokeIPS3_JPS6_SF_SH_EEEvSJ_OT_DpOT0_
STDERR: #6 0x7fa6cda25140
_ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN5blink26InProcessWorkerObjectProxyEFvN3WTF10PassRefPtrINS4_21SerializedScriptValueEEENS6_6VectorISt10unique_ptrINS4_21WebMessagePortChannelESt14default_deleteISC_EELm1ENS6_18PartitionAllocatorEEEPNS4_12WorkerThreadEEJPS5_PS8_SH_SJ_EEEvOT_DpOT0_
STDERR: #7 0x7fa6cda2507e
_ZN4base8internal7InvokerINS0_9BindStateIMN5blink26InProcessWorkerObjectProxyEFvN3WTF10PassRefPtrINS3_21SerializedScriptValueEEENS5_6VectorISt10unique_ptrINS3_21WebMessagePortChannelESt14default_deleteISB_EELm1ENS5_18PartitionAllocatorEEEPNS3_12WorkerThreadEEJNS5_17UnretainedWrapperIS4_LNS5_22FunctionThreadAffinityE0EEENS5_6RefPtrIS7_EENS5_13PassedWrapperISG_EENSL_ISH_LSM_0EEEEEEFvvEE7RunImplIRKSK_RKSt5tupleIJSN_SP_SR_SS_EEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
STDERR: #8 0x7fa6cda24efc
_ZN4base8internal7InvokerINS0_9BindStateIMN5blink26InProcessWorkerObjectProxyEFvN3WTF10PassRefPtrINS3_21SerializedScriptValueEEENS5_6VectorISt10unique_ptrINS3_21WebMessagePortChannelESt14default_deleteISB_EELm1ENS5_18PartitionAllocatorEEEPNS3_12WorkerThreadEEJNS5_17UnretainedWrapperIS4_LNS5_22FunctionThreadAffinityE0EEENS5_6RefPtrIS7_EENS5_13PassedWrapperISG_EENSL_ISH_LSM_0EEEEEEFvvEE3RunEPNS0_13BindStateBaseE
STDERR: #9 0x7fa6cad37a1d
_ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
STDERR: #10 0x7fa6cad37959 WTF::Function<>::operator()()
STDERR: #11 0x7fa6cad36a91 blink::(anonymous namespace)::RunCrossThreadClosure()
STDERR: #12 0x7fa6cad38597
_ZN4base8internal13FunctorTraitsIPFvSt10unique_ptrIN3WTF8FunctionIFvvELNS3_22FunctionThreadAffinityE0EEESt14default_deleteIS7_EEEvE6InvokeIJSA_EEEvSC_DpOT_
STDERR: #13 0x7fa6cad384f8
_ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvSt10unique_ptrIN3WTF8FunctionIFvvELNS5_22FunctionThreadAffinityE0EEESt14default_deleteIS9_EEEJSC_EEEvOT_DpOT0_
STDERR: #14 0x7fa6cad384a7
_ZN4base8internal7InvokerINS0_9BindStateIPFvSt10unique_ptrIN3WTF8FunctionIFvvELNS4_22FunctionThreadAffinityE0EEESt14default_deleteIS8_EEEJNS0_13PassedWrapperISB_EEEEES6_E7RunImplIRKSD_RKSt5tupleIJSF_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
STDERR: #15 0x7fa6cad383ec
_ZN4base8internal7InvokerINS0_9BindStateIPFvSt10unique_ptrIN3WTF8FunctionIFvvELNS4_22FunctionThreadAffinityE0EEESt14default_deleteIS8_EEEJNS0_13PassedWrapperISB_EEEEES6_E3RunEPNS0_13BindStateBaseE
STDERR: #16 0x7fa6d50f7cee
_ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
STDERR: #17 0x7fa6d50f742e base::debug::TaskAnnotator::RunTask()
STDERR: #18 0x7fa6cb186fee
blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
STDERR: #19 0x7fa6cb183f76 blink::scheduler::TaskQueueManager::DoWork()
STDERR: #20 0x7fa6cb18f2e4
_ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKbEEEvS6_OT_DpOT0_
STDERR: #21 0x7fa6cb18f1ef
_ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvbERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_
STDERR: #22 0x7fa6cb18f163
_ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_bEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
STDERR: #23 0x7fa6cb18f07c
_ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE
STDERR: #24 0x7fa6d50f7cee
_ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
STDERR: #25 0x7fa6d50f742e base::debug::TaskAnnotator::RunTask()
STDERR: #26 0x7fa6d518a0bd base::MessageLoop::RunTask()
STDERR: #27 0x7fa6d518a344 base::MessageLoop::DeferOrRunPendingTask()
STDERR: #28 0x7fa6d518a634 base::MessageLoop::DoWork()
STDERR: #29 0x7fa6d51a1e28 base::MessagePumpDefault::Run()
STDERR: #30 0x7fa6d5189c57 base::MessageLoop::RunHandler()
STDERR: #31 0x7fa6d523276a base::RunLoop::Run()
STDERR: #32 0x7fa6d52d82e4 base::Thread::Run()
STDERR: #33 0x7fa6d52d8b4a base::Thread::ThreadMain()
STDERR: #34 0x7fa6d52bf87a base::(anonymous namespace)::ThreadFunc()
STDERR: #35 0x7fa6da883184 start_thread
STDERR: #36 0x7fa6c693fbed clone
STDERR:

[horo, 2017-04-27 08:31:12]

I changed termination-early.html to call postMessage() 10000 times.

[nhiroki, 2017-04-27 08:33:37]

Thank you! This is really helpful :)

[commit-bot: I haz the power, 2017-04-27 08:45:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 08:45:56]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-27 09:52:02]

Patchset #2 (id:20001) has been deleted

[nhiroki, 2017-05-01 01:58:03]

This crash was fixed (see the issue), so I'll close this review. Thank you for
your help!

[nhiroki, 2017-05-01 01:58:22]

Description was changed from

==========
Worker: Add checks in InProcessWorkerObjectProxy for debug

BUG=713914
==========

to

==========
Worker: Add checks in InProcessWorkerObjectProxy for debug

BUG=713914
==========