Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc

Issue 2846733004: Optimization: not sending answer server requests for voice queries. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc
diff --git a/chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc b/chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc
index 08af8884a8f4d1fc49703d00bc974ef42845cb1d..ad1940e394ee63263218f4664d7016f4edcda6c6 100644
--- a/chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc
+++ b/chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc
@@ -53,7 +53,7 @@ views::View* SearchAnswerWebContentsDelegate::web_view() {
return web_view_.get();
}
-void SearchAnswerWebContentsDelegate::Update() {
+void SearchAnswerWebContentsDelegate::Update(bool is_voice_query) {
if (!answer_server_url_.is_valid())
return;
@@ -62,6 +62,12 @@ void SearchAnswerWebContentsDelegate::Update() {
model_->SetSearchAnswerAvailable(false);
current_request_url_ = GURL();
+ if (is_voice_query) {
+ // No need to send a server request and show a card because launcher
+ // automatically closes upon voice queries.
+ return;
+ }
+
if (!model_->search_engine_is_google())
return;

Powered by Google App Engine
This is Rietveld 408576698