Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: chromeos/dbus/shill_profile_client.h

Issue 284673004: Improve functionality of FakeShillProfileClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_profile_client.h
diff --git a/chromeos/dbus/shill_profile_client.h b/chromeos/dbus/shill_profile_client.h
index b237fb0524f99767e1c2a1d2e4630f321aec8d9a..c5e724740df65a366b91f4fae15032366230af4e 100644
--- a/chromeos/dbus/shill_profile_client.h
+++ b/chromeos/dbus/shill_profile_client.h
@@ -58,14 +58,30 @@ class CHROMEOS_EXPORT ShillProfileClient : public DBusClient {
const base::DictionaryValue& properties) = 0;
// Adds a service to the profile, copying properties from the
- // ShillServiceClient entry (which must be present). Also sets the Profile
- // property of the service in ShillServiceClient.
+ // ShillServiceClient entry. Returns false if no Service entry exists or
+ // if a Profile entry already exists. Also sets the Profile property of
+ // the service in ShillServiceClient.
virtual bool AddService(const std::string& profile_path,
const std::string& service_path) = 0;
+ // Updates an existing profile service entry. Returns false if no entry
pneubeck (no reviews) 2014/05/14 08:12:17 unclear what 'Updates' means.
stevenjb 2014/05/14 17:08:10 Done.
+ // exists.
+ virtual bool UpdateService(const std::string& profile_path,
+ const std::string& service_path) = 0;
+
// Sets |profiles| to the current list of profile paths.
virtual void GetProfilePaths(std::vector<std::string>* profiles) = 0;
+ // Sets |properties| to the entry for |service_path|, sets |profile_path|
+ // to the path of the profile with the entry, and returns true if the
+ // service exists in any profile.
+ virtual bool GetService(const std::string& service_path,
+ std::string* profile_path,
+ base::DictionaryValue* properties) = 0;
+
+ // Remove all profile entries.
+ virtual void ClearProfiles() = 0;
+
protected:
virtual ~TestInterface() {}
};

Powered by Google App Engine
This is Rietveld 408576698