Improve functionality of FakeShillProfileClient

chromeos/dbus/fake_shill_profile_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_FAKE_SHILL_PROFILE_CLIENT_H_
 #define CHROMEOS_DBUS_FAKE_SHILL_PROFILE_CLIENT_H_
 
 #include <map>
 #include <string>
 
@@ skipping 35 matching lines @@
   virtual ShillProfileClient::TestInterface* GetTestInterface() OVERRIDE;
 
   // ShillProfileClient::TestInterface overrides.
   virtual void AddProfile(const std::string& profile_path,
                           const std::string& userhash) OVERRIDE;
   virtual void AddEntry(const std::string& profile_path,
                         const std::string& entry_path,
                         const base::DictionaryValue& properties) OVERRIDE;
   virtual bool AddService(const std::string& profile_path,
                           const std::string& service_path) OVERRIDE;
+  virtual bool UpdateService(const std::string& profile_path,
+                             const std::string& service_path) OVERRIDE;
   virtual void GetProfilePaths(std::vector<std::string>* profiles) OVERRIDE;
+  virtual bool GetService(const std::string& service_path,
+                          std::string* profile_path,
+                          base::DictionaryValue* properties) OVERRIDE;
+  virtual void ClearProfiles() OVERRIDE;
 
  private:
   struct ProfileProperties;
   typedef std::map<std::string, ProfileProperties*> ProfileMap;
 
+  bool AddOrUpdateServiceImpl(ProfileProperties* profile,

[pneubeck (no reviews), 2014/05/14 08:12:17]

argument order: profile (because non-const) should be at the end.

[stevenjb, 2014/05/14 17:08:10]

Done.

+                              const std::string& profile_path,
+                              const std::string& service_path);
+
   ProfileProperties* GetProfile(const dbus::ObjectPath& profile_path,
                                 const ErrorCallback& error_callback);
 
   // The values are owned by this class and are explicitly destroyed where
   // necessary.
   ProfileMap profiles_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeShillProfileClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_FAKE_SHILL_PROFILE_CLIENT_H_