Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 2846723005: Use ScopedTaskEnvironment instead of MessageLoopForUI in components tests. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index 527770396f70b29e551f263e49e6a66a98deeb13..09121da021597a108e7402f463a490aac974b5e8 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -32,6 +32,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_MACOSX)
+#include "base/test/scoped_task_environment.h"
gab 2017/04/28 01:43:00 Wrong include block
fdoray 2017/05/01 17:16:51 Done.
#include "components/os_crypt/os_crypt_mocker.h"
#endif
@@ -89,6 +90,10 @@ class StartSyncFlareMock {
class PasswordStoreTest : public testing::Test {
protected:
+ PasswordStoreTest()
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI) {}
+
void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); }
void TearDown() override { ASSERT_TRUE(temp_dir_.Delete()); }
@@ -97,7 +102,7 @@ class PasswordStoreTest : public testing::Test {
return temp_dir_.GetPath().Append(FILE_PATH_LITERAL("login_test"));
}
- base::MessageLoopForUI message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
base::ScopedTempDir temp_dir_;
};

Powered by Google App Engine
This is Rietveld 408576698