components/history/core/test/history_backend_db_base_test.h - Issue 2846723005: Use ScopedTaskEnvironment instead of MessageLoopForUI in components tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/test/history_backend_db_base_test.h

Issue 2846723005: Use ScopedTaskEnvironment instead of MessageLoopForUI in components tests. (Closed)

Patch Set: fix-test-errors Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/test/history_backend_db_base_test.h

diff --git a/components/history/core/test/history_backend_db_base_test.h b/components/history/core/test/history_backend_db_base_test.h

index 31798fd45c18c6095d96b4c64c7c4124d47b8539..1c5cfd5685d1caf191845e158c67193d473f608c 100644

--- a/components/history/core/test/history_backend_db_base_test.h

+++ b/components/history/core/test/history_backend_db_base_test.h

@@ -13,7 +13,7 @@

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

#include "base/memory/ref_counted.h"

-#include "base/message_loop/message_loop.h"

+#include "base/test/scoped_task_environment.h"

#include "components/history/core/test/history_unittest_base.h"

#include "sql/init_status.h"

@@ -59,7 +59,7 @@ class HistoryBackendDBBaseTest : public HistoryUnitTestBase {

base::ScopedTempDir temp_dir_;

- base::MessageLoopForUI message_loop_;

+ base::test::ScopedTaskEnvironment scoped_task_environment_;

// names of the database files

base::FilePath history_dir_;