Use ScopedTaskEnvironment instead of MessageLoopForUI in components tests.

components/password_manager/core/browser/password_store_default_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_store_default.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/scoped_task_environment.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "components/password_manager/core/browser/login_database.h"
 #include "components/password_manager/core/browser/password_manager_test_utils.h"
 #include "components/password_manager/core/browser/password_store_change.h"
 #include "components/password_manager/core/browser/password_store_consumer.h"
 #include "components/password_manager/core/browser/password_store_origin_unittest.h"
 #include "components/prefs/pref_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 43 matching lines @@
                            L"password_element",
                            L"username_value",
                            L"password_value",
                            true,
                            1};
   return data;
 }
 
 class PasswordStoreDefaultTestDelegate {
  public:
-  PasswordStoreDefaultTestDelegate();
   explicit PasswordStoreDefaultTestDelegate(
-      std::unique_ptr<LoginDatabase> database);
+      std::unique_ptr<LoginDatabase> database)
+      : scoped_task_environment_(
+            base::test::ScopedTaskEnvironment::MainThreadType::UI) {}

[gab, 2017/04/28 01:43:00]

Deleting the default constructor and forcing this one here are both unepxected
(already defined below)

[fdoray, 2017/05/01 17:16:51]

Done.

   ~PasswordStoreDefaultTestDelegate();
 
   PasswordStoreDefault* store() { return store_.get(); }
 
   static void FinishAsyncProcessing();
 
  private:
   void SetupTempDir();
 
   void ClosePasswordStore();
 
   scoped_refptr<PasswordStoreDefault> CreateInitializedStore(
       std::unique_ptr<LoginDatabase> database);
 
   base::FilePath test_login_db_file_path() const;
 
-  base::MessageLoopForUI message_loop_;
+  base::test::ScopedTaskEnvironment scoped_task_environment_;
   base::ScopedTempDir temp_dir_;
   scoped_refptr<PasswordStoreDefault> store_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStoreDefaultTestDelegate);
 };
 
 PasswordStoreDefaultTestDelegate::PasswordStoreDefaultTestDelegate() {

[sdefresne, 2017/04/28 10:00:23]

scoped_task_environment_ needs to be initialized here

[fdoray, 2017/05/01 17:16:51]

Done.

   SetupTempDir();
   store_ = CreateInitializedStore(
       base::MakeUnique<LoginDatabase>(test_login_db_file_path()));
 }
 
 PasswordStoreDefaultTestDelegate::PasswordStoreDefaultTestDelegate(

[sdefresne, 2017/04/28 10:00:23]

ditto

[fdoray, 2017/05/01 17:16:51]

Done.

     std::unique_ptr<LoginDatabase> database) {
   SetupTempDir();
   store_ = CreateInitializedStore(std::move(database));
 }
 
 PasswordStoreDefaultTestDelegate::~PasswordStoreDefaultTestDelegate() {
   ClosePasswordStore();
 }
 
 void PasswordStoreDefaultTestDelegate::FinishAsyncProcessing() {
@@ skipping 171 matching lines @@
   run_loop.Run();
 
   bad_store->RemoveLoginsSyncedBetween(base::Time(), base::Time::Max());
   base::RunLoop().RunUntilIdle();
 
   // Ensure no notifications and no explosions during shutdown either.
   bad_store->RemoveObserver(&mock_observer);
 }
 
 }  // namespace password_manager