Use ScopedTaskEnvironment instead of MessageLoopForUI in components tests.

components/autofill/content/browser/risk/fingerprint_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/browser/risk/fingerprint.h"
 
 #include <stdint.h>
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
 #include "build/build_config.h"
 #include "components/autofill/content/browser/risk/proto/fingerprint.pb.h"
 #include "content/public/browser/gpu_data_manager.h"
 #include "content/public/common/screen_info.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/test_utils.h"
 #include "device/geolocation/geolocation_provider.h"
 #include "device/geolocation/geoposition.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 37 matching lines @@
 // should be serialized into the resulting protocol buffer.
 const double kLatitude = -42.0;
 const double kLongitude = 17.3;
 const double kAltitude = 123.4;
 const double kAccuracy = 73.7;
 const int kGeolocationTime = 87;
 
 class AutofillRiskFingerprintTest : public content::ContentBrowserTest {
  public:
   AutofillRiskFingerprintTest()
-      : window_bounds_(2, 3, 5, 7),
+      : scoped_task_environment_(
+            base::test::ScopedTaskEnvironment::MainThreadType::UI),
+        window_bounds_(2, 3, 5, 7),
         content_bounds_(11, 13, 17, 37),
         screen_bounds_(0, 0, 101, 71),
         available_screen_bounds_(0, 11, 101, 60),
         unavailable_screen_bounds_(0, 0, 101, 11) {}
 
   void GetFingerprintTestCallback(std::unique_ptr<Fingerprint> fingerprint) {
     // Verify that all fields Chrome can fill have been filled.
     ASSERT_TRUE(fingerprint->has_machine_characteristics());
     const Fingerprint::MachineCharacteristics& machine =
         fingerprint->machine_characteristics();
@@ skipping 78 matching lines @@
               transient_state.outer_window_size().width());
     EXPECT_EQ(window_bounds_.height(),
               transient_state.outer_window_size().height());
     EXPECT_EQ(kObfuscatedGaiaId, fingerprint->metadata().obfuscated_gaia_id());
     EXPECT_EQ(kAltitude, location.altitude());
     EXPECT_EQ(kLatitude, location.latitude());
     EXPECT_EQ(kLongitude, location.longitude());
     EXPECT_EQ(kAccuracy, location.accuracy());
     EXPECT_EQ(kGeolocationTime, location.time_in_ms());
 
-    message_loop_.QuitWhenIdle();
+    base::MessageLoop::current()->QuitWhenIdle();

[sdefresne, 2017/04/28 10:00:23]

Shouldn't this use base::RunLoop().RunUntilIdle()?

[fdoray, 2017/05/01 17:16:50]

Removed this file from this CL since it requires non-trivial refactoring.

   }
 
  protected:
+  base::test::ScopedTaskEnvironment scoped_task_environment_;
+
   // Constants defining bounds in the screen coordinate system that are passed
   // verbatim to the fingerprinter code and should be serialized into the
   // resulting protocol buffer.  Declared as class members because gfx::Rect is
   // not a POD type, so it cannot be statically initialized.
   const gfx::Rect window_bounds_;
   const gfx::Rect content_bounds_;
   const gfx::Rect screen_bounds_;
   const gfx::Rect available_screen_bounds_;
   const gfx::Rect unavailable_screen_bounds_;
-
-  // A message loop to block on the asynchronous loading of the fingerprint.
-  base::MessageLoopForUI message_loop_;
 };
 
 // Test that getting a fingerprint works on some basic level.
 IN_PROC_BROWSER_TEST_F(AutofillRiskFingerprintTest, GetFingerprint) {
   device::Geoposition position;
   position.latitude = kLatitude;
   position.longitude = kLongitude;
   position.altitude = kAltitude;
   position.accuracy = kAccuracy;
   position.timestamp =
@@ skipping 14 matching lines @@
       base::TimeDelta::FromDays(1),  // Ought to be longer than any test run.
       base::Bind(&AutofillRiskFingerprintTest::GetFingerprintTestCallback,
                  base::Unretained(this)));
 
   // Wait for the callback to be called.
   base::RunLoop().Run();
 }
 
 }  // namespace risk
 }  // namespace autofill