[MD settings] separate all-sites from site-list

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 
 /**
  * An example pref with 2 blocked location items and 2 allowed. This pref
  * is also used for the All Sites category and therefore needs values for
  * all types, even though some might be blank.
@@ skipping 132 matching lines @@
         origin: 'https://bar.com',
         embeddingOrigin: '',
         setting: 'allow',
         source: 'preference',
       },
     ],
   }
 };
 
 /**
- * An example pref with mixed origin and pattern.
- * @type {SiteSettingsPref}
- */
-var prefsMixedOriginAndPattern = {
-  exceptions: {
-    auto_downloads: [],
-    background_sync: [],
-    camera: [],
-    cookies: [],
-    geolocation: [
-      {
-        origin: 'https://foo.com',
-        embeddingOrigin: 'https://example.com',
-        setting: 'allow',
-        source: 'preference',
-      },
-    ],
-    images: [],
-    javascript: [
-      {
-        origin: 'https://[*.]foo.com',
-        embeddingOrigin: '',
-        setting: 'allow',
-        source: 'preference',
-      },
-    ],
-    mic: [],
-    notifications: [],
-    plugins: [],
-    midiDevices: [],
-    protectedContent: [],
-    popups: [],
-    subresource_filter: [],
-    unsandboxed_plugins: [],
-  }
-};
-
-/**
  * An example pref with multiple categories and multiple allow/block
  * state.
  * @type {SiteSettingsPref}
  */
 var prefsVarious = {
   exceptions: {
     auto_downloads: [],
     background_sync: [],
     camera: [],
     cookies: [],
@@ skipping 255 matching lines @@
   }
 
   /**
    * Configures the test element for a particular category.
    * @param {settings.ContentSettingsTypes} category The category to set up.
    * @param {settings.PermissionValues} subtype Type of list to use.
    * @param {Array<dictionary>} prefs The prefs to use.
    */
   function setUpCategory(category, subtype, prefs) {
     browserProxy.setPrefs(prefs);
-    if (category == settings.ALL_SITES) {
-      testElement.categorySubtype = settings.INVALID_CATEGORY_SUBTYPE;
-      testElement.allSites = true;
-    } else {
-      testElement.categorySubtype = subtype;
-      testElement.allSites = false;
-    }
+    testElement.categorySubtype = subtype;
     // Some route is needed, but the actual route doesn't matter.
     testElement.currentRoute = {
       page: 'dummy',
       section: 'privacy',
       subpage: ['site-settings', 'site-settings-category-location'],
     };
     testElement.category = category;
   }
 
   test('read-only attribute', function() {
@@ skipping 434 matching lines @@
     var contentType = settings.ContentSettingsTypes.GEOLOCATION;
     setUpCategory(
         contentType, settings.PermissionValues.ALLOW, prefsOneDisabled);
     return browserProxy.whenCalled('getExceptionList')
         .then(function(actualContentType) {
           assertEquals(contentType, actualContentType);
           assertFalse(testElement.$.category.hidden);
         });
   });
 
-  test('All sites category no action menu', function() {
-    setUpCategory(settings.ALL_SITES, '', prefsVarious);
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function(contentType) {
-          // Use resolver to ensure that the list container is populated.
-          var resolver = new PromiseResolver();
-          testElement.async(resolver.resolve);
-          return resolver.promise.then(function() {
-            var item = testElement.$.listContainer.children[0];
-            var dots = item.querySelector('#actionMenuButton');
-            assertTrue(!!dots);
-            assertTrue(dots.hidden);
-          });
-        });
-  });
-
-  test('All sites category', function() {
-    // Prefs: Multiple and overlapping sites.
-    setUpCategory(settings.ALL_SITES, '', prefsVarious);
-
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function(contentType) {
-          // Use resolver to ensure asserts bubble up to the framework with
-          // meaningful errors.
-          var resolver = new PromiseResolver();
-          testElement.async(resolver.resolve);
-          return resolver.promise.then(function() {
-            // All Sites calls getExceptionList for all categories, starting
-            // with Cookies.
-            assertEquals(settings.ContentSettingsTypes.COOKIES, contentType);
-
-            // Required for firstItem to be found below.
-            Polymer.dom.flush();
-
-            assertFalse(testElement.$.category.hidden);
-            // Validate that the sites gets populated from pre-canned prefs.
-            assertEquals(
-                3, testElement.sites.length,
-                'If this fails with 5 instead of the expected 3, then ' +
-                    'the de-duping of sites is not working for site_list');
-            assertEquals(
-                prefsVarious.exceptions.geolocation[1].origin,
-                testElement.sites[0].origin);
-            assertEquals(
-                prefsVarious.exceptions.geolocation[0].origin,
-                testElement.sites[1].origin);
-            assertEquals(
-                prefsVarious.exceptions.notifications[0].origin,
-                testElement.sites[2].origin);
-            assertEquals(undefined, testElement.selectedOrigin);
-
-            // Validate that the sites are shown in UI and can be selected.
-            var firstItem = testElement.$.listContainer.children[1];
-            var clickable = firstItem.querySelector('.middle');
-            assertNotEquals(undefined, clickable);
-            MockInteractions.tap(clickable);
-            assertEquals(
-                prefsVarious.exceptions.geolocation[0].origin,
-                settings.getQueryParameters().get('site'));
-          });
-        });
-  });
-
-  test('All sites mixed pattern and origin', function() {
-    // Prefs: One site, represented as origin and pattern.
-    setUpCategory(settings.ALL_SITES, '', prefsMixedOriginAndPattern);
-
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function(contentType) {
-          // Use resolver to ensure asserts bubble up to the framework with
-          // meaningful errors.
-          var resolver = new PromiseResolver();
-          testElement.async(resolver.resolve);
-          return resolver.promise.then(function() {
-            // All Sites calls getExceptionList for all categories, starting
-            // with Cookies.
-            assertEquals(settings.ContentSettingsTypes.COOKIES, contentType);
-
-            // Required for firstItem to be found below.
-            Polymer.dom.flush();
-
-            assertFalse(testElement.$.category.hidden);
-            // Validate that the sites gets populated from pre-canned prefs.
-            // TODO(dschuyler): de-duping of sites is under discussion, so
-            // it is currently disabled. It should be enabled again or this
-            // code should be removed.
-            assertEquals(
-                2, testElement.sites.length,
-                'If this fails with 1 instead of the expected 2, then ' +
-                    'the de-duping of sites has been enabled for site_list.');
-            if (testElement.sites.length == 1) {
-              assertEquals(
-                  prefsMixedOriginAndPattern.exceptions.geolocation[0].origin,
-                  testElement.sites[0].displayName);
-            }
-
-            assertEquals(undefined, testElement.selectedOrigin);
-            // Validate that the sites are shown in UI and can be selected.
-            var firstItem = testElement.$.listContainer.children[0];
-            var clickable = firstItem.querySelector('.middle');
-            assertNotEquals(undefined, clickable);
-            MockInteractions.tap(clickable);
-            if (testElement.sites.length == 1) {
-              assertEquals(
-                  prefsMixedOriginAndPattern.exceptions.geolocation[0].origin,
-                  testElement.sites[0].displayName);
-            }
-          });
-        });
-  });
-
   test('Mixed embeddingOrigin', function() {
     setUpCategory(
         settings.ContentSettingsTypes.IMAGES, settings.PermissionValues.ALLOW,
         prefsMixedEmbeddingOrigin);
     return browserProxy.whenCalled('getExceptionList')
         .then(function(contentType) {
           // Required for firstItem to be found below.
           Polymer.dom.flush();
           // Validate that embeddingOrigin sites cannot be edited.
           var firstItem = testElement.$.listContainer.children[0];
@@ skipping 199 matching lines @@
     input.value = expectedPattern;
     input.fire('input');
 
     return browserProxy.whenCalled('isPatternValid').then(function(pattern) {
       assertEquals(expectedPattern, pattern);
       assertTrue(actionButton.disabled);
       assertTrue(input.invalid);
     });
   });
 });