components/history/core/browser/url_database.cc - Issue 2846673006: Omnibox: Make InMemoryURLIndex respect hidden URLRows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/url_database.cc

Issue 2846673006: Omnibox: Make InMemoryURLIndex respect hidden URLRows (Closed)

Patch Set: address mpearson comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/url_database.cc

diff --git a/components/history/core/browser/url_database.cc b/components/history/core/browser/url_database.cc

index 248ecf47d865bd0944aad9a375fd9fa7f433977e..0c08d4b9d62835e220abcdb9fd65b1aae624ac24 100644

--- a/components/history/core/browser/url_database.cc

+++ b/components/history/core/browser/url_database.cc

@@ -639,6 +639,9 @@ base::Time AutocompleteAgeThreshold() {

bool RowQualifiesAsSignificant(const URLRow& row,

const base::Time& threshold) {

+ if (row.hidden())

+ return false;

const base::Time& real_threshold =

threshold.is_null() ? AutocompleteAgeThreshold() : threshold;

return (row.typed_count() >= kLowQualityMatchTypedLimit) ||