Omnibox: Make InMemoryURLIndex respect hidden URLRows

components/omnibox/browser/history_quick_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/history_quick_provider.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <functional>
@@ skipping 234 matching lines @@
       {"http://visitedest.com/y/a", "VA", 10, 1, 20},
       {"http://visitedest.com/y/b", "VB", 9, 1, 20},
       {"http://visitedest.com/x/c", "VC", 8, 1, 20},
       {"http://visitedest.com/x/d", "VD", 7, 1, 20},
       {"http://visitedest.com/y/e", "VE", 6, 1, 20},
       {"http://typeredest.com/y/a", "TA", 5, 5, 0},
       {"http://typeredest.com/y/b", "TB", 5, 4, 0},
       {"http://typeredest.com/x/c", "TC", 5, 3, 0},
       {"http://typeredest.com/x/d", "TD", 5, 2, 0},
       {"http://typeredest.com/y/e", "TE", 5, 1, 0},
+      {"http://nevertyped.com/", "NA", 20, 0, 0},
       {"http://daysagoest.com/y/a", "DA", 1, 1, 0},
       {"http://daysagoest.com/y/b", "DB", 1, 1, 1},
       {"http://daysagoest.com/x/c", "DC", 1, 1, 2},
       {"http://daysagoest.com/x/d", "DD", 1, 1, 3},
       {"http://daysagoest.com/y/e", "DE", 1, 1, 4},
       {"http://abcdefghixyzjklmnopqrstuvw.com/a", "", 3, 1, 0},
       {"http://spaces.com/path%20with%20spaces/foo.html", "Spaces", 2, 2, 0},
       {"http://abcdefghijklxyzmnopqrstuvw.com/a", "", 3, 1, 0},
       {"http://abcdefxyzghijklmnopqrstuvw.com/a", "", 3, 1, 0},
       {"http://abcxyzdefghijklmnopqrstuvw.com/a", "", 3, 1, 0},
@@ skipping 256 matching lines @@
 TEST_F(HistoryQuickProviderTest, TypedCountMatches) {
   std::vector<std::string> expected_urls;
   expected_urls.push_back("http://typeredest.com/y/a");
   expected_urls.push_back("http://typeredest.com/y/b");
   expected_urls.push_back("http://typeredest.com/x/c");
   RunTest(ASCIIToUTF16("typeredest"), false, expected_urls, true,
           ASCIIToUTF16("typeredest.com/y/a"),
                     ASCIIToUTF16(".com/y/a"));
 }
 
+TEST_F(HistoryQuickProviderTest, NeverTypedMatchesCantBeDefault) {
+  std::vector<std::string> expected_urls;
+  expected_urls.push_back("http://nevertyped.com/");

[Peter Kasting, 2017/04/28 06:02:13]

Nit: Just init at the definition with = {...} instead of define + push_back.

[tommycli, 2017/04/28 15:44:11]

Done.

+  RunTest(ASCIIToUTF16("neverty"), false, expected_urls, false,
+          ASCIIToUTF16("nevertyped.com"), ASCIIToUTF16("ped.com/"));
+}
+
 TEST_F(HistoryQuickProviderTest, DaysAgoMatches) {
   std::vector<std::string> expected_urls;
   expected_urls.push_back("http://daysagoest.com/y/a");
   expected_urls.push_back("http://daysagoest.com/y/b");
   expected_urls.push_back("http://daysagoest.com/x/c");
   RunTest(ASCIIToUTF16("daysagoest"), false, expected_urls, true,
           ASCIIToUTF16("daysagoest.com/y/a"),
                     ASCIIToUTF16(".com/y/a"));
 }
 
@@ skipping 280 matching lines @@
 
 TEST_F(HQPOrderingTest, TEAMatch) {
   std::vector<std::string> expected_urls;
   expected_urls.push_back("http://www.teamliquid.net/");
   expected_urls.push_back("http://www.teamliquid.net/tlpd");
   expected_urls.push_back("http://www.teamliquid.net/tlpd/korean/players");
   RunTest(ASCIIToUTF16("tea"), false, expected_urls, true,
           ASCIIToUTF16("www.teamliquid.net"),
                  ASCIIToUTF16("mliquid.net"));
 }