Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2161)

Unified Diff: base/test/gtest_xml_unittest_result_printer.h

Issue 2846673004: Set limit for number of failed EXPECTs per test in test launcher output. (Closed)
Patch Set: Move --test-launcher-test-part-limit switch handling to printer. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/gtest_xml_unittest_result_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/gtest_xml_unittest_result_printer.h
diff --git a/base/test/gtest_xml_unittest_result_printer.h b/base/test/gtest_xml_unittest_result_printer.h
index cce5e88023a045f0de48486ee35de995a980d3df..4ca17192437a8bc55ebc3b19cd0984d6d56a2516 100644
--- a/base/test/gtest_xml_unittest_result_printer.h
+++ b/base/test/gtest_xml_unittest_result_printer.h
@@ -46,6 +46,13 @@ class XmlUnitTestResultPrinter : public testing::EmptyTestEventListener {
FILE* output_file_;
+ // Some tests may contain broken EXPECT with a large message inside a loop
+ // with several thousands iterations and produce huge output (several
+ // gigabytes). Limit number of serialized test result parts to prevent it.
+ // Zero value disables test part results.
+ // Negative value disables limit.
+ int test_part_results_limit_;
Paweł Hajdan Jr. 2017/05/08 17:38:03 Is it worth to add a member variable just for this
alex-ac 2017/05/12 12:07:44 Done.
+
DISALLOW_COPY_AND_ASSIGN(XmlUnitTestResultPrinter);
};
« no previous file with comments | « no previous file | base/test/gtest_xml_unittest_result_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698