cc : Stop pushing layers from hidden subtrees at commit

cc/trees/tree_synchronizer.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/tree_synchronizer.h"
 
 #include <stddef.h>
 
 #include <set>
 
@@ skipping 75 matching lines @@
 
 static bool LayerHasValidPropertyTreeIndices(LayerImpl* layer) {
   DCHECK(layer);
   return layer->transform_tree_index() != TransformTree::kInvalidNodeId &&
          layer->effect_tree_index() != EffectTree::kInvalidNodeId &&
          layer->clip_tree_index() != ClipTree::kInvalidNodeId &&
          layer->scroll_tree_index() != ScrollTree::kInvalidNodeId;
 }
 #endif
 
+static bool IsHidden(Layer* layer) {
+  return layer->is_hidden();
+}
+
+static bool IsHidden(LayerImpl* layer) {
+  return false;
+}
+
 template <typename LayerTreeType>
 void PushLayerList(OwnedLayerImplMap* old_layers,
                    LayerTreeType* host,
                    LayerTreeImpl* tree_impl) {
   tree_impl->ClearLayerList();
   for (auto* layer : *host) {
-    std::unique_ptr<LayerImpl> layer_impl(
-        ReuseOrCreateLayerImpl(old_layers, layer, tree_impl));
+    // TODO(crbug.com/726535) : Try not pushing all skipped layers and not just
+    // the hidden layers here.
+    if (!IsHidden(layer)) {
+      std::unique_ptr<LayerImpl> layer_impl(
+          ReuseOrCreateLayerImpl(old_layers, layer, tree_impl));
 
 #if DCHECK_IS_ON()
-    // Every layer should have valid property tree indices
-    AssertValidPropertyTreeIndices(layer);
-    // Every layer_impl should either have valid property tree indices already
-    // or the corresponding layer should push them onto layer_impl.
-    DCHECK(LayerHasValidPropertyTreeIndices(layer_impl.get()) ||
-           host->LayerNeedsPushPropertiesForTesting(layer));
+      // Every layer should have valid property tree indices
+      AssertValidPropertyTreeIndices(layer);
+      // Every layer_impl should either have valid property tree indices already
+      // or the corresponding layer should push them onto layer_impl.
+      DCHECK(LayerHasValidPropertyTreeIndices(layer_impl.get()) ||
+             host->LayerNeedsPushPropertiesForTesting(layer));
 #endif
-
-    tree_impl->AddToLayerList(layer_impl.get());
-    tree_impl->AddLayer(std::move(layer_impl));
+      tree_impl->AddToLayerList(layer_impl.get());
+      tree_impl->AddLayer(std::move(layer_impl));
+    }
   }
   tree_impl->OnCanDrawStateChangedForTree();
 }
 
 template <typename LayerType>
 static void PushLayerPropertiesInternal(
     std::unordered_set<LayerType*> layers_that_should_push_properties,
     LayerTreeImpl* impl_tree) {
   for (auto layer : layers_that_should_push_properties) {
-    LayerImpl* layer_impl = impl_tree->LayerById(layer->id());
-    DCHECK(layer_impl);
-    layer->PushPropertiesTo(layer_impl);
+    if (!IsHidden(layer)) {
+      LayerImpl* layer_impl = impl_tree->LayerById(layer->id());
+      DCHECK(layer_impl);
+      layer->PushPropertiesTo(layer_impl);
+    }
   }
 }
 
 void TreeSynchronizer::PushLayerProperties(LayerTreeImpl* pending_tree,
                                            LayerTreeImpl* active_tree) {
   PushLayerPropertiesInternal(pending_tree->LayersThatShouldPushProperties(),
                               active_tree);
 }
 
 void TreeSynchronizer::PushLayerProperties(LayerTreeHost* host_tree,
                                            LayerTreeImpl* impl_tree) {
   PushLayerPropertiesInternal(host_tree->LayersThatShouldPushProperties(),
                               impl_tree);
 }
 
 }  // namespace cc