cc : Stop pushing layers from hidden subtrees at commit

cc/trees/layer_tree_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 1198 matching lines @@
   gfx::SizeF content_size = root_scroll_layer->BoundsForScrolling();
   content_size.SetToMax(root_container_layer->BoundsForScrolling());
   return content_size;
 }
 
 LayerImpl* LayerTreeImpl::LayerById(int id) const {
   LayerImplMap::const_iterator iter = layer_id_map_.find(id);
   return iter != layer_id_map_.end() ? iter->second : nullptr;
 }
 
+using SurfaceIdsList = std::vector<const SurfaceId*>;

[enne (OOO), 2017/05/19 22:27:05]

I think this should be SurfaceId and not SurfaceId*.  Lifetimes seem a little
bit scary here.

Also in general, I think std::vector<const SurfaceId> isn't really much longer
than SurfaceIdsList and is a lot clearer.  If you don't mind avoiding the
typedef, I'd appreciate it.

[jaydasika, 2017/05/23 00:25:14]

Done.

+void LayerTreeImpl::SetHiddenSurfaceLayerIds(
+    const SurfaceIdsList* hidden_surface_layer_ids) {

[enne (OOO), 2017/05/19 22:27:05]

Maybe pass by const ref here?

[jaydasika, 2017/05/23 00:25:14]

Done.

+  DCHECK(hidden_surface_layer_ids_.empty());
+  hidden_surface_layer_ids_ = *hidden_surface_layer_ids;
+}
+
+const SurfaceIdsList* LayerTreeImpl::HiddenSurfaceLayerIds() const {

[enne (OOO), 2017/05/19 22:27:05]

Maybe a const ref and not a pointer, if it's never going to be null?

[jaydasika, 2017/05/23 00:25:14]

Done.

+  return &hidden_surface_layer_ids_;
+}
+
+void LayerTreeImpl::ClearHiddenSurfaceLayerIds() {
+  hidden_surface_layer_ids_.clear();
+}
+
 void LayerTreeImpl::AddLayerShouldPushProperties(LayerImpl* layer) {
   layers_that_should_push_properties_.insert(layer);
 }
 
 void LayerTreeImpl::RemoveLayerShouldPushProperties(LayerImpl* layer) {
   layers_that_should_push_properties_.erase(layer);
 }
 
 std::unordered_set<LayerImpl*>&
 LayerTreeImpl::LayersThatShouldPushProperties() {
@@ skipping 872 matching lines @@
 
 void LayerTreeImpl::ResetAllChangeTracking() {
   layers_that_should_push_properties_.clear();
   // Iterate over all layers, including masks.
   for (auto& layer : *layers_)
     layer->ResetChangeTracking();
   property_trees_.ResetAllChangeTracking();
 }
 
 }  // namespace cc