third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp - Issue 2846593008: Proactively dispose image filters for SVG filter chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

Issue 2846593008: Proactively dispose image filters for SVG filter chains (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

index 3e4d10830c54b038a28a0101b643390dd215448f..5c2f9bb8859ab083d8281b017dc50ccff2f08cfd 100644

--- a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

@@ -93,7 +93,7 @@ void SVGFilterGraphNodeMap::InvalidateDependentEffects(FilterEffect* effect) {

if (!effect->HasImageFilter())

return;

- effect->ClearResult();

+ effect->DisposeImageFilters();

FilterEffectSet& effect_references = this->EffectReferences(effect);

for (FilterEffect* effect_reference : effect_references)