third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 2846593004: Don't log xvfb errors under normal circumstances in run-webkit-tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2846593004: Don't log xvfb errors under normal circumstances in run-webkit-tests (Closed)

Patch Set: suppress startup/shutdown messages as well Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index e8a091007f0301dfaf8828acb5e487e5d7386a56..f3d5b322ed5a4b5aa28ae9e786cfd216c7282b04 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -357,7 +357,6 @@ class Port(object):

def error_handler(script_error):

local_error.exit_code = script_error.exit_code

- _log.warn('DISPLAY = %s', self.host.environ.get('DISPLAY', ''))

mithro 2017/05/09 02:00:09 Could we make this a _log.debug?

Dirk Pranke 2017/05/09 03:42:20 Sure.

output = self._executive.run_command(cmd, error_handler=error_handler)

if local_error.exit_code:

_log.error('System dependencies check failed.')