third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h - Issue 2846523002: Update the stringifier behavior for DOMMatrixReadOnly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

Issue 2846523002: Update the stringifier behavior for DOMMatrixReadOnly (Closed)

Patch Set: Update the stringifier behavior for DOMMatrixReadOnly Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

diff --git a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

index 05f7f339612b76a6958e9626a92c69e95a0b666c..96aa4fa7853987269e6a07c10e8fdd06674a239c 100644

--- a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

+++ b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

@@ -64,6 +64,7 @@ class CORE_EXPORT DOMMatrixReadOnly

bool is2D() const;

bool isIdentity() const;

+ bool isNaNorInf(double x) const;

zino 2017/05/16 22:25:37 nit: Please remove this?

Byoungkwon Ko 2017/05/18 13:52:14 Done.

DOMMatrix* multiply(DOMMatrixInit&, ExceptionState&);

DOMMatrix* translate(double tx = 0, double ty = 0, double tz = 0);

@@ -97,7 +98,7 @@ class CORE_EXPORT DOMMatrixReadOnly

NotShared<DOMFloat32Array> toFloat32Array() const;

NotShared<DOMFloat64Array> toFloat64Array() const;

- const String toString() const;

+ const String toString(ExceptionState&) const;

ScriptValue toJSONForBinding(ScriptState*) const;