Update the stringifier behavior for DOMMatrixReadOnly

third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/geometry/DOMMatrixReadOnly.h"
 
 #include "bindings/core/v8/V8ObjectBuilder.h"
 #include "core/css/CSSIdentifierValue.h"
 #include "core/css/CSSToLengthConversionData.h"
 #include "core/css/CSSValueList.h"
@@ skipping 300 matching lines @@
 NotShared<DOMFloat64Array> DOMMatrixReadOnly::toFloat64Array() const {
   double array[] = {
       matrix_->M11(), matrix_->M12(), matrix_->M13(), matrix_->M14(),
       matrix_->M21(), matrix_->M22(), matrix_->M23(), matrix_->M24(),
       matrix_->M31(), matrix_->M32(), matrix_->M33(), matrix_->M34(),
       matrix_->M41(), matrix_->M42(), matrix_->M43(), matrix_->M44()};
 
   return NotShared<DOMFloat64Array>(DOMFloat64Array::Create(array, 16));
 }
 
-const String DOMMatrixReadOnly::toString() const {
-  std::stringstream stream;
+const String DOMMatrixReadOnly::toString(
+    ExceptionState& exception_state) const {
+  const char* kComma = ", ";
+  String result;
+
   if (is2D()) {
-    stream << "matrix(" << a() << ", " << b() << ", " << c() << ", " << d()
-           << ", " << e() << ", " << f();
-  } else {
-    stream << "matrix3d(" << m11() << ", " << m12() << ", " << m13() << ", "
-           << m14() << ", " << m21() << ", " << m22() << ", " << m23() << ", "
-           << m24() << ", " << m31() << ", " << m32() << ", " << m33() << ", "
-           << m34() << ", " << m41() << ", " << m42() << ", " << m43() << ", "
-           << m44();
+    if (std::isfinite(a()) || std::isfinite(b()) || std::isfinite(c()) ||

[zino, 2017/05/18 16:15:38]

Shouldn't be && instead of || as follows:
std::isfinite(a()) && std::isfinite(b()) ...

[fserb, 2017/05/18 17:10:55]

actually, shouldn't it be !std::isfinite(a()) || !std::isfinite(b()) .. ?

[zino, 2017/05/18 18:19:02]

Yeah it's the same. :) (de morgan's law)

+        std::isfinite(d()) || std::isfinite(e()) || std::isfinite(f())) {
+      exception_state.ThrowDOMException(
+          kInvalidStateError,
+          "DOMMatrix does not support NaN and Infinity values.");

[fserb, 2017/05/18 17:10:55]

This is false.
"DOMMatrix cannot be serialized with NaN or Infinity values."

+      return String();
+    }
+
+    result.append("matrix(");
+    result.append(String::NumberToStringECMAScript(a()));
+    result.append(kComma);
+    result.append(String::NumberToStringECMAScript(b()));
+    result.append(kComma);
+    result.append(String::NumberToStringECMAScript(c()));
+    result.append(kComma);
+    result.append(String::NumberToStringECMAScript(d()));
+    result.append(kComma);
+    result.append(String::NumberToStringECMAScript(e()));
+    result.append(kComma);
+    result.append(String::NumberToStringECMAScript(f()));
+    result.append(")");
+    return result;
   }
-  stream << ")";
 
-  return String(stream.str().c_str());
+  if (std::isfinite(m11()) || std::isfinite(m12()) || std::isfinite(m13()) ||

[fserb, 2017/05/18 17:10:55]

same as above.

+      std::isfinite(m14()) || std::isfinite(m21()) || std::isfinite(m22()) ||
+      std::isfinite(m23()) || std::isfinite(m24()) || std::isfinite(m31()) ||
+      std::isfinite(m32()) || std::isfinite(m33()) || std::isfinite(m34()) ||
+      std::isfinite(m41()) || std::isfinite(m42()) || std::isfinite(m43()) ||
+      std::isfinite(m44())) {
+    exception_state.ThrowDOMException(
+        kInvalidStateError,
+        "DOMMatrix does not support NaN and infinity values.");

[fserb, 2017/05/18 17:10:55]

same as above.

+    return String();
+  }
+
+  result.append("matrix3d(");
+  result.append(String::NumberToStringECMAScript(m11()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m12()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m13()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m14()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m21()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m22()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m23()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m24()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m31()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m32()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m33()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m34()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m41()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m42()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m43()));
+  result.append(kComma);
+  result.append(String::NumberToStringECMAScript(m44()));
+  result.append(")");
+
+  return result;
 }
 
 ScriptValue DOMMatrixReadOnly::toJSONForBinding(
     ScriptState* script_state) const {
   V8ObjectBuilder result(script_state);
   result.AddNumber("a", a());
   result.AddNumber("b", b());
   result.AddNumber("c", c());
   result.AddNumber("d", d());
   result.AddNumber("e", e());
@@ skipping 62 matching lines @@
 
   matrix_->MakeIdentity();
   operations.Apply(FloatSize(0, 0), *matrix_);
 
   is2d_ = !operations.Has3DOperation();
 
   return;
 }
 
 }  // namespace blink