third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash.html - Issue 2846513002: More targeted resource-switching mechanism for SVG selection painting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash.html

Issue 2846513002: More targeted resource-switching mechanism for SVG selection painting (Closed)

Patch Set: Rebased onto dependent patch(es) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash-expected.txt » ('j') | third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 ::selection {

	4 page-break-before: right;

	5 }

	6 </style>

	7 <script>

	8 if (window.testRunner) {

	9 testRunner.dumpAsText();

	10 testRunner.waitUntilDone();

	11 }

	12 onload = function() {

	13 document.body.offsetTop;
	Stephen Chennney 2017/04/28 16:12:31 This might be to force layout. Can it be switched This might be to force layout. Can it be switched to runAfterLayoutAndPaint and still crash? fs 2017/04/28 18:16:33 Yes, we want layout to be clean before adding the Show quoted text On 2017/04/28 at 16:12:31, Stephen Chennney wrote: > This might be to force layout. Can it be switched to runAfterLayoutAndPaint and still crash? Yes, we want layout to be clean before adding the filter (and selection) in the following line(s), then the rAF change will trigger style recalc (for the document) and subsequent paint. rALAP might work too since it should provide a layout, but I didn't not attempt to use it there. fs 2017/05/02 13:53:32 I tried inserting a runAfterLayoutAndPaint to repl Show quoted text On 2017/04/28 at 18:16:33, fs wrote: > On 2017/04/28 at 16:12:31, Stephen Chennney wrote: > > This might be to force layout. Can it be switched to runAfterLayoutAndPaint and still crash? > > Yes, we want layout to be clean before adding the filter (and selection) in the following line(s), then the rAF change will trigger style recalc (for the document) and subsequent paint. rALAP might work too since it should provide a layout, but I didn't not attempt to use it there. I tried inserting a runAfterLayoutAndPaint to replace the offsetTop, and then the crash no longer reproduced. I noticed that I needed to replace the first rAF with rALAP after the testharness conversion though, so did that in PS5.
	14 document.getElementById("text1").setAttribute("filter", "url(#f)");

	15 document.execCommand("SelectAll", false);

	16

	17 requestAnimationFrame(function() {

	18 document.vlinkColor = "#ff0000";

	19 requestAnimationFrame(function() { testRunner.notifyDone(); });

	20 });

	21 }

	22 </script>

	23 <p>PASS if no crash</p>

	24 <svg id="svg1">

	25 <text>Text2</text>

	26 </svg>

	27 <svg>

	28 <text id="text1">Text</text>

	29 </svg>

	30 <svg>

	31 <filter id="f">

	32 <feImage xlink:href="#svg1"/>

	33 </filter>

	34 </svg>

OLD	NEW