third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash-expected.txt - Issue 2846513002: More targeted resource-switching mechanism for SVG selection painting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash-expected.txt

Issue 2846513002: More targeted resource-switching mechanism for SVG selection painting (Closed)

Patch Set: Rebased onto dependent patch(es) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash.html ('K') | « third_party/WebKit/LayoutTests/svg/text/selection-pseudo-resource-invalidation-crash.html ('k') | third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.h » ('j') | third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 PASS if no crash
	chrishtr 2017/04/28 18:39:23 Use testharness.js to avoid the expectation file. Use testharness.js to avoid the expectation file. Example in https://codereview.chromium.org/2844593002 fs 2017/04/28 18:59:52 Not a big fan of using testharness just to be able Show quoted text On 2017/04/28 at 18:39:23, chrishtr wrote: > Use testharness.js to avoid the expectation file. Example in https://codereview.chromium.org/2844593002 Not a big fan of using testharness just to be able to get rid of the expected file TBH. Granted it's a bit silly that we should be needing expectation files for tests like this... I can rewrite it though if you prefer. chrishtr 2017/04/28 19:59:39 Well I just was reminded about it yesterday via a Show quoted text On 2017/04/28 at 18:59:52, fs wrote: > On 2017/04/28 at 18:39:23, chrishtr wrote: > > Use testharness.js to avoid the expectation file. Example in https://codereview.chromium.org/2844593002 > > Not a big fan of using testharness just to be able to get rid of the expected file TBH. Granted it's a bit silly that we should be needing expectation files for tests like this... I can rewrite it though if you prefer. Well I just was reminded about it yesterday via a code review from Morten. Since it is just including two script files and calling test() it seems like a good thing to do to me. fs 2017/04/28 20:18:41 Convert to testharness and removed -expected.txt f Show quoted text On 2017/04/28 at 19:59:39, chrishtr wrote: > On 2017/04/28 at 18:59:52, fs wrote: > > On 2017/04/28 at 18:39:23, chrishtr wrote: > > > Use testharness.js to avoid the expectation file. Example in https://codereview.chromium.org/2844593002 > > > > Not a big fan of using testharness just to be able to get rid of the expected file TBH. Granted it's a bit silly that we should be needing expectation files for tests like this... I can rewrite it though if you prefer. > > Well I just was reminded about it yesterday via a code review from Morten. Since it is just including > two script files and calling test() it seems like a good thing to do to me. Convert to testharness and removed -expected.txt file.
	2

	3 Text2

	4

	5 Text

	6

OLD	NEW