Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

Issue 2846463003: Instrument analyzer's type analysis and run front_end inference tests. (Closed)
Patch Set: Updates. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/analysis/driver.dart ('k') | pkg/analyzer/lib/src/dart/ast/ast.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
index 4987624e24c485b77471c59be6a9b6a5434db4c8..bb90bb4a507ae57c00a67b73fc2db51e8c6ca614 100644
--- a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
@@ -16,6 +16,7 @@ import 'package:analyzer/src/dart/constant/evaluation.dart';
import 'package:analyzer/src/dart/constant/utilities.dart';
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/error/pending_error.dart';
+import 'package:analyzer/src/fasta/uri_instrumentation.dart';
import 'package:analyzer/src/generated/declaration_resolver.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/error_verifier.dart';
@@ -25,6 +26,7 @@ import 'package:analyzer/src/services/lint.dart';
import 'package:analyzer/src/summary/package_bundle_reader.dart';
import 'package:analyzer/src/task/dart.dart';
import 'package:analyzer/src/task/strong/checker.dart';
+import 'package:front_end/src/base/instrumentation.dart' as fasta;
import 'package:front_end/src/dependency_walker.dart';
/**
@@ -37,6 +39,7 @@ class LibraryAnalyzer {
final FileSystemState _fsState;
final SummaryDataStore _store;
final FileState _library;
+ final fasta.Instrumentation _instrumentation;
TypeProvider _typeProvider;
AnalysisContextImpl _context;
@@ -53,8 +56,14 @@ class LibraryAnalyzer {
final Map<FileState, List<PendingError>> _fileToPendingErrors = {};
final List<ConstantEvaluationTarget> _constants = [];
- LibraryAnalyzer(this._analysisOptions, this._declaredVariables,
- this._sourceFactory, this._fsState, this._store, this._library);
+ LibraryAnalyzer(
+ this._analysisOptions,
+ this._declaredVariables,
+ this._sourceFactory,
+ this._fsState,
+ this._store,
+ this._library,
+ this._instrumentation);
/**
* Compute analysis results for all units of the library.
@@ -512,6 +521,10 @@ class LibraryAnalyzer {
RecordingErrorListener errorListener = _getErrorListener(file);
+ UriInstrumentation instrumentation = _instrumentation != null
+ ? new UriInstrumentation(_instrumentation, file.uri)
+ : null;
+
CompilationUnitElement unitElement = unit.element;
// TODO(scheglov) Hack: set types for top-level variables
@@ -522,6 +535,9 @@ class LibraryAnalyzer {
for (var e in unitElement.topLevelVariables) {
if (!e.isSynthetic) {
e.type;
+ if (instrumentation != null && e.hasImplicitType) {
+ instrumentation.recordTopType(e.nameOffset, e.type);
+ }
}
}
@@ -549,7 +565,8 @@ class LibraryAnalyzer {
// Nothing for RESOLVED_UNIT10?
unit.accept(new ResolverVisitor(
- _libraryElement, source, _typeProvider, errorListener));
+ _libraryElement, source, _typeProvider, errorListener,
+ instrumentation: instrumentation));
//
// Find constants to compute.
« no previous file with comments | « pkg/analyzer/lib/src/dart/analysis/driver.dart ('k') | pkg/analyzer/lib/src/dart/ast/ast.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698