Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2846463003: Instrument analyzer's type analysis and run front_end inference tests. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Instrument analyzer's type analysis and run front_end inference tests. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cf013c646917eafe314f848081792f27b89af92f

Patch Set 1 #

Patch Set 2 : Updates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -31 lines) Patch
M pkg/analyzer/analyzer.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 7 chunks +20 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/fasta/uri_instrumentation.dart View 1 chunk +113 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 7 chunks +18 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +102 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/front_end.iml View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/base/instrumentation.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/int_upwards_local.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/local_constructor_from_arguments.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/toplevel_inference_toplevel_var.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart.dartk.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart.strong.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart.dartk.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart.outline.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart.strong.expect View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 7 months ago (2017-04-26 19:14:34 UTC) #1
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-04-26 19:26:11 UTC) #2
Paul Berry
lgtm
3 years, 7 months ago (2017-04-26 19:49:48 UTC) #3
scheglov
3 years, 7 months ago (2017-04-26 20:31:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cf013c646917eafe314f848081792f27b89af92f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698