Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 284643002: Hpack fuzzing tweaks to address CHECK failures on ClusterFuzz (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton, inferno
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Hpack fuzzing tweaks to address CHECK failures on ClusterFuzz * Be tolerant of truncated files. These happen in practice if the fuzzer runs out of disk space. * Clear the decoder's input buffer if decoding fails. * Relax third-stage decoder checks, as there are valid cases where the second-stage encoder produces an output which the decoder will refuse. BUG=353237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269951

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M net/spdy/fuzzing/hpack_fuzz_util.cc View 2 chunks +16 lines, -7 lines 1 comment Download
M net/spdy/hpack_decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnny
6 years, 7 months ago (2014-05-12 20:57:49 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/284643002/diff/1/net/spdy/fuzzing/hpack_fuzz_util.cc File net/spdy/fuzzing/hpack_fuzz_util.cc (right): https://codereview.chromium.org/284643002/diff/1/net/spdy/fuzzing/hpack_fuzz_util.cc#newcode170 net/spdy/fuzzing/hpack_fuzz_util.cc:170: if (!context->third_stage->HandleControlFrameHeadersComplete(1)) { Up to you, but you ...
6 years, 7 months ago (2014-05-12 21:05:49 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-12 22:28:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/284643002/1
6 years, 7 months ago (2014-05-12 22:28:39 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 01:10:47 UTC) #5
Message was sent while issue was closed.
Change committed as 269951

Powered by Google App Engine
This is Rietveld 408576698