Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2303)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 2846413002: Switch SupportsUserData uses to use unique_ptr. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index 75320e06cb3a55b4c006e7f3b6a6cb63c1df4dd0..3e7ff15e4a9f4ad6e4dbb94a28147d95cce83810 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -496,12 +496,12 @@ void WebstoreInstaller::OnDownloadStarted(
if (version_required.IsValid()) {
approval->minimum_version.reset(new base::Version(version_required));
}
- download_item_->SetUserData(kApprovalKey, approval.release());
+ download_item_->SetUserData(kApprovalKey, std::move(approval));
} else {
// It is for the main module of the extension. We should use the provided
// |approval_|.
if (approval_)
- download_item_->SetUserData(kApprovalKey, approval_.release());
+ download_item_->SetUserData(kApprovalKey, std::move(approval_));
}
if (!download_started_) {
« no previous file with comments | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698