chrome/common/chrome_constants.h - Issue 2846383002: Improve JumpList icon folders' naming style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_constants.h

Issue 2846383002: Improve JumpList icon folders' naming style (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/chrome_constants.h

diff --git a/chrome/common/chrome_constants.h b/chrome/common/chrome_constants.h

index a0c67803c3454c2ea3d7a67e1b1f084d17ef4abd..00e26d057d5365b85ff47c1875c5c0f4578e8860 100644

--- a/chrome/common/chrome_constants.h

+++ b/chrome/common/chrome_constants.h

@@ -72,7 +72,7 @@ extern const base::FilePath::CharType kThemePackFilename[];

extern const base::FilePath::CharType kWebAppDirname[];

#if defined(OS_WIN)

-extern const base::FilePath::CharType kJumpListIconDirname[];

+extern const base::FilePath::StringType kJumpListIconDirname;

grt (UTC plus 2) 2017/05/01 09:22:56 this must remain a CharType array since introducin

chengx 2017/05/03 05:47:01 Done. I've reverted the changes in chrome_constant

#endif

// File name of the Pepper Flash plugin on different platforms.