chrome/browser/data_use_measurement/data_use_web_contents_observer.cc - Issue 2846333004: Switch SupportsUserData uses to use unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

Issue 2846333004: Switch SupportsUserData uses to use unique_ptr. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc ('k') | chrome/browser/font_family_cache.cc » ('j') | chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

diff --git a/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc b/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

index 9d20afa48083ab17068573a7cc581b8e3244954b..91170f23fdfdbf10532bc1cbfcb19db4b6e7b93a 100644

--- a/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

+++ b/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/data_use_measurement/data_use_web_contents_observer.h"

+#include "base/memory/ptr_util.h"

#include "chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h"

#include "chrome/browser/data_use_measurement/chrome_data_use_ascriber_service_factory.h"

#include "content/public/browser/navigation_handle.h"

@@ -34,7 +35,8 @@ void DataUseWebContentsObserver::CreateForWebContents(

// tied to a profile. Since profiles outlive |WebContents|, |service| will

// outlive |DataUseWebContentsObserver|.

web_contents->SetUserData(

- UserDataKey(), new DataUseWebContentsObserver(web_contents, service));

+ UserDataKey(),

+ base::WrapUnique(new DataUseWebContentsObserver(web_contents, service)));

Nico 2017/05/02 20:54:09 does MakeUnique<> not work here?

}

DataUseWebContentsObserver::DataUseWebContentsObserver(