Make PlatformFileForTransit its own class on Windows.

ipc/ipc_platform_file.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_PLATFORM_FILE_H_
 #define IPC_IPC_PLATFORM_FILE_H_
 
 #include "base/files/file.h"
 #include "base/process/process.h"
 #include "build/build_config.h"
 #include "ipc/ipc_export.h"
 
 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
 #endif
 
-#if defined(OS_WIN)
-#include "base/memory/shared_memory_handle.h"
-#endif
-
 namespace IPC {
 
 #if defined(OS_WIN)
 // The semantics for IPC transfer of a SharedMemoryHandle are exactly the same

[Mark Seaborn, 2017/04/28 22:45:21]

I think this reference to SharedMemoryHandle needs to be updated.

[erikchen, 2017/04/28 23:24:37]

This whole comment is no longer meaningful. Removed.

 // as for a PlatformFileForTransit. The object wraps a HANDLE, and has some
 // metadata that indicates the process to which the HANDLE belongs.

[Mark Seaborn, 2017/04/28 22:45:21]

PlatformFileForTransit no longer has this metadata, right?

[erikchen, 2017/04/28 23:24:37]

This whole comment is no longer meaningful. Removed.

-using PlatformFileForTransit = base::SharedMemoryHandle;
+class IPC_EXPORT PlatformFileForTransit {
+ public:
+  // Creates an invalid platform file.
+  PlatformFileForTransit();
+
+  // Creates a platform file that takes unofficial ownership of |handle|. Note
+  // that ownership is not handled by a Scoped* class due to usage patterns of
+  // this class and its POSIX counterpart [base::FileDescriptor]. When this
+  // class is used as an input to an IPC message, the IPC subsystem will close
+  // |handle|. When this class is used as the output from an IPC message, the
+  // receiver is expected to take ownership of |handle|.
+  explicit PlatformFileForTransit(HANDLE handle);
+
+  // Comparison operators.
+  bool operator==(const PlatformFileForTransit& platform_file) const;
+  bool operator!=(const PlatformFileForTransit& platform_file) const;
+
+  HANDLE GetHandle() const;
+  bool IsValid() const;
+
+ private:
+  HANDLE handle_;
+};
 #elif defined(OS_POSIX)
 typedef base::FileDescriptor PlatformFileForTransit;
 #endif
 
 inline PlatformFileForTransit InvalidPlatformFileForTransit() {
 #if defined(OS_WIN)
   return PlatformFileForTransit();
 #elif defined(OS_POSIX)
   return base::FileDescriptor();
 #endif
@@ skipping 24 matching lines @@
     bool close_source_handle);
 
 // Creates a new handle that can be passed through IPC. The result must be
 // passed to the IPC layer as part of a message, or else it will leak.
 // Note that this function takes ownership of |file|.
 IPC_EXPORT PlatformFileForTransit TakePlatformFileForTransit(base::File file);
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_PLATFORM_FILE_H_