third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2846283002: Replace ASSERT_NOT_REACHED with NOTREACHED in the rest of core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2846283002: Replace ASSERT_NOT_REACHED with NOTREACHED in the rest of core/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp ('k') | third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index a01d69e0839f12a2cad5a875720a675e92694ef3..9d4e5c14c0e8de4d66f367f8eff7ae977eaba06c 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -179,7 +179,7 @@ static CSSValue* ValueForFillSourceType(EMaskSourceType type) {

return CSSIdentifierValue::Create(CSSValueLuminance);

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return nullptr;

}

@@ -284,7 +284,7 @@ static CSSValue* ValueForPositionOffset(const ComputedStyle& style,

(layout_box->OffsetHeight() + client_offset.Height());

break;

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

return ZoomAdjustedPixelValue(position, style);

}