Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2846283002: Replace ASSERT_NOT_REACHED with NOTREACHED in the rest of core/ (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1737 matching lines...) Expand 10 before | Expand all | Expand 10 after
1748 adjusted = BestClickableNodeForHitTestResult( 1748 adjusted = BestClickableNodeForHitTestResult(
1749 *hit_test_result, adjusted_point, adjusted_node); 1749 *hit_test_result, adjusted_point, adjusted_node);
1750 break; 1750 break;
1751 case WebInputEvent::kGestureLongPress: 1751 case WebInputEvent::kGestureLongPress:
1752 case WebInputEvent::kGestureLongTap: 1752 case WebInputEvent::kGestureLongTap:
1753 case WebInputEvent::kGestureTwoFingerTap: 1753 case WebInputEvent::kGestureTwoFingerTap:
1754 adjusted = BestContextMenuNodeForHitTestResult( 1754 adjusted = BestContextMenuNodeForHitTestResult(
1755 *hit_test_result, adjusted_point, adjusted_node); 1755 *hit_test_result, adjusted_point, adjusted_node);
1756 break; 1756 break;
1757 default: 1757 default:
1758 ASSERT_NOT_REACHED(); 1758 NOTREACHED();
1759 } 1759 }
1760 1760
1761 // Update the hit-test result to be a point-based result instead of a 1761 // Update the hit-test result to be a point-based result instead of a
1762 // rect-based result. 1762 // rect-based result.
1763 // FIXME: We should do this even when no candidate matches the node filter. 1763 // FIXME: We should do this even when no candidate matches the node filter.
1764 // crbug.com/398914 1764 // crbug.com/398914
1765 if (adjusted) { 1765 if (adjusted) {
1766 hit_test_result->ResolveRectBasedTest( 1766 hit_test_result->ResolveRectBasedTest(
1767 adjusted_node, frame_->View()->RootFrameToContents(adjusted_point)); 1767 adjusted_node, frame_->View()->RootFrameToContents(adjusted_point));
1768 gesture_event->ApplyTouchAdjustment( 1768 gesture_event->ApplyTouchAdjustment(
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
2117 MouseEventWithHitTestResults& mev, 2117 MouseEventWithHitTestResults& mev,
2118 LocalFrame* subframe) { 2118 LocalFrame* subframe) {
2119 WebInputEventResult result = 2119 WebInputEventResult result =
2120 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event()); 2120 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event());
2121 if (result != WebInputEventResult::kNotHandled) 2121 if (result != WebInputEventResult::kNotHandled)
2122 return result; 2122 return result;
2123 return WebInputEventResult::kHandledSystem; 2123 return WebInputEventResult::kHandledSystem;
2124 } 2124 }
2125 2125
2126 } // namespace blink 2126 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698