third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2846273002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2846273002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/frame (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 94240cc36f5d5310e64dbc667047c32ee3455fb4..b3a6cccd727c828ee2713060dcbb50726ee2de42 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -4114,7 +4114,7 @@ void FrameView::UpdateScrollOffset(const ScrollOffset& offset,

if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

// Don't scroll the FrameView!

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

scroll_offset_ = offset;