Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2846273002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/frame (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 return 559; 1086 return 559;
1087 case CSSPropertyPlaceSelf: 1087 case CSSPropertyPlaceSelf:
1088 return 560; 1088 return 560;
1089 // 1. Add new features above this line (don't change the assigned numbers of 1089 // 1. Add new features above this line (don't change the assigned numbers of
1090 // the existing items). 1090 // the existing items).
1091 // 2. Update kMaximumCSSSampleId with the new maximum value. 1091 // 2. Update kMaximumCSSSampleId with the new maximum value.
1092 // 3. Run the update_use_counter_css.py script in 1092 // 3. Run the update_use_counter_css.py script in
1093 // chromium/src/tools/metrics/histograms to update the UMA histogram names. 1093 // chromium/src/tools/metrics/histograms to update the UMA histogram names.
1094 1094
1095 case CSSPropertyInvalid: 1095 case CSSPropertyInvalid:
1096 ASSERT_NOT_REACHED(); 1096 NOTREACHED();
1097 return 0; 1097 return 0;
1098 } 1098 }
1099 1099
1100 ASSERT_NOT_REACHED(); 1100 NOTREACHED();
1101 return 0; 1101 return 0;
1102 } 1102 }
1103 1103
1104 UseCounter::UseCounter(Context context) 1104 UseCounter::UseCounter(Context context)
1105 : mute_count_(0), 1105 : mute_count_(0),
1106 disable_reporting_(false), 1106 disable_reporting_(false),
1107 context_(context), 1107 context_(context),
1108 features_recorded_(kNumberOfFeatures), 1108 features_recorded_(kNumberOfFeatures),
1109 css_recorded_(numCSSPropertyIDs), 1109 css_recorded_(numCSSPropertyIDs),
1110 animated_css_recorded_(numCSSPropertyIDs) {} 1110 animated_css_recorded_(numCSSPropertyIDs) {}
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
1412 } 1412 }
1413 } 1413 }
1414 1414
1415 if (needs_pages_measured_update) 1415 if (needs_pages_measured_update)
1416 css_properties_histogram.Count(totalPagesMeasuredCSSSampleId()); 1416 css_properties_histogram.Count(totalPagesMeasuredCSSSampleId());
1417 1417
1418 css_bits_.ClearAll(); 1418 css_bits_.ClearAll();
1419 } 1419 }
1420 1420
1421 } // namespace blink 1421 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp ('k') | third_party/WebKit/Source/core/frame/VisualViewport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698