chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java - Issue 2846233003: 📰 Record user actions on the NTP and Home sheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java

Issue 2846233003: 📰 Record user actions on the NTP and Home sheet (Closed)

Patch Set: Address bauerb@'s comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java ('k') | chrome/android/java_sources.gni » ('j') | tools/metrics/actions/actions.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java

index da233f302e948c0cb4215aa106f1f6a9f2ac3971..cd3903aadf2b31f8af0c13d075d79bd8ab6b22e6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java

@@ -153,7 +153,6 @@ public void onAction(Object actionData) {

}

private void recordOpenedTile(Tile tile) {

- // TODO(mvanouwerkerk): Fix metrics to distinguish NTP from Home.

NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_MOST_VISITED_TILE);

RecordUserAction.record("MobileNTPMostVisited");

NewTabPageUma.recordExplicitUserNavigation(