[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

ios/chrome/browser/tabs/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 source_set("tabs") {
   sources = [
     "legacy_tab_helper.h",
     "tab.h",
     "tab_delegate.h",
     "tab_dialog_delegate.h",
@@ skipping 15 matching lines @@
     "//ios/net",
     "//ios/web",
     "//ios/web:user_agent",
     "//ui/base",
   ]
   libs = [ "UIKit.framework" ]
 }
 
 source_set("tabs_internal") {
   sources = [
-    "tab.h",
-    "tab.mm",
     "tab_model.mm",
     "tab_model_synced_window_delegate.mm",
     "tab_model_synced_window_delegate_getter.mm",
   ]
   deps = [

[rohitrao (ping after 24h), 2017/05/02 11:42:53]

Can any of these deps be removed, now that tab.mm is no longer in this target?

[sdefresne, 2017/05/02 15:08:51]

"tabs_internal" & "tabs_internal_arc" will be merged in the third CL converting
"tabs_internal" to ARC. I've already added all the required dependencies to
"tabs_internal_arc", so I'll do the merge by removing "tabs_internal" and
renaming "tabs_internal_arc" to "tabs_internal".

Cleanup this list of dependencies has low value and I don't think it should be
done.

     ":tabs",
     ":tabs_internal_arc",
     "//base",
     "//components/content_settings/core/browser",
     "//components/favicon/core",
     "//components/favicon/ios",
     "//components/google/core/browser",
     "//components/history/core/browser",
     "//components/history/ios/browser",
     "//components/infobars/core",
@@ skipping 64 matching lines @@
   allow_circular_includes_from = [ ":tabs_internal_arc" ]
   libs = [
     "CoreLocation.framework",
     "UIKit.framework",
   ]
 }
 
 source_set("tabs_internal_arc") {
   sources = [
     "legacy_tab_helper.mm",
+    "tab.h",
+    "tab.mm",
     "tab_helper_util.mm",
     "tab_model_closing_web_state_observer.h",
     "tab_model_closing_web_state_observer.mm",
     "tab_model_list.mm",
     "tab_model_observers.h",
     "tab_model_observers.mm",
     "tab_model_observers_bridge.h",
     "tab_model_observers_bridge.mm",
     "tab_model_selected_tab_observer.h",
     "tab_model_selected_tab_observer.mm",
     "tab_model_web_state_list_delegate.h",
     "tab_model_web_state_list_delegate.mm",
     "tab_parenting_observer.h",
     "tab_parenting_observer.mm",
   ]
   deps = [
     ":tabs",
     "//base",
+    "//components/content_settings/core/browser",
+    "//components/favicon/core",
     "//components/favicon/ios",
+    "//components/google/core/browser",
     "//components/history/core/browser",
     "//components/history/ios/browser",
+    "//components/infobars/core",
     "//components/keyed_service/core",
+    "//components/metrics_services_manager",
+    "//components/navigation_metrics",
+    "//components/prefs",
+    "//components/reading_list/core",
+    "//components/search_engines",
     "//components/sessions",
+    "//components/signin/core/browser",
     "//components/signin/ios/browser",
+    "//components/strings",
+    "//components/url_formatter",
+    "//ios/chrome/app/strings",
     "//ios/chrome/browser",
+    "//ios/chrome/browser/autofill",
+    "//ios/chrome/browser/autofill:autofill_internal",
     "//ios/chrome/browser/bookmarks",
     "//ios/chrome/browser/browser_state",
+    "//ios/chrome/browser/content_settings",
     "//ios/chrome/browser/favicon",
     "//ios/chrome/browser/find_in_page",
-    "//ios/chrome/browser/find_in_page",
+    "//ios/chrome/browser/geolocation:geolocation_internal",
     "//ios/chrome/browser/history",
     "//ios/chrome/browser/infobars",
+    "//ios/chrome/browser/metrics",
+    "//ios/chrome/browser/metrics:metrics_internal",
+    "//ios/chrome/browser/native_app_launcher:native_app_launcher_internal",
+    "//ios/chrome/browser/passwords",
+    "//ios/chrome/browser/passwords:passwords_internal",
     "//ios/chrome/browser/reading_list",
+    "//ios/chrome/browser/search_engines",
     "//ios/chrome/browser/sessions",
+    "//ios/chrome/browser/sessions:serialisation",
     "//ios/chrome/browser/signin",
+    "//ios/chrome/browser/signin:signin_internal",
+    "//ios/chrome/browser/snapshots",
+    "//ios/chrome/browser/snapshots:snapshots_internal",
     "//ios/chrome/browser/ssl",
     "//ios/chrome/browser/store_kit",
     "//ios/chrome/browser/sync",
     "//ios/chrome/browser/translate",
+    "//ios/chrome/browser/u2f",
+    "//ios/chrome/browser/ui",
+    "//ios/chrome/browser/ui:ui_internal",
+    "//ios/chrome/browser/ui/alert_coordinator",
+    "//ios/chrome/browser/ui/commands",
+    "//ios/chrome/browser/ui/downloads",
+    "//ios/chrome/browser/ui/overscroll_actions",
+    "//ios/chrome/browser/ui/reader_mode",
+    "//ios/chrome/browser/ui/sad_tab",
+    "//ios/chrome/browser/ui/toolbar",
+    "//ios/chrome/browser/ui/util",
     "//ios/chrome/browser/web",
+    "//ios/chrome/browser/web:sad_tab_tab_helper_delegate",
     "//ios/chrome/browser/web:web_internal",
     "//ios/chrome/browser/web_state_list",
+    "//ios/net",
     "//ios/public/provider/chrome/browser",
+    "//ios/public/provider/chrome/browser/native_app_launcher",
     "//ios/web",
+    "//ios/web:user_agent",
+    "//net",
+    "//ui/base",
     "//url",
   ]
-  libs = [ "Foundation.framework" ]
+  libs = [
+    "CoreLocation.framework",
+    "Foundation.framework",
+    "UIKit.framework",
+  ]
   configs += [ "//build/config/compiler:enable_arc" ]
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
     "tab_model_unittest.mm",
     "tab_unittest.mm",
   ]
   deps = [
@@ skipping 37 matching lines @@
     ":tabs",
     ":tabs_internal",
     "//base",
     "//ios/chrome/browser/browser_state:test_support",
     "//ios/chrome/browser/sessions:test_support",
     "//ios/web:test_support",
     "//testing/gtest",
   ]
   configs += [ "//build/config/compiler:enable_arc" ]
 }